-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logger structure #981
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
50371b8
Add datadog logging structure
ricardoMogg 6712c81
add logging examples
ricardoMogg 087b4eb
remove tracer for testing
ricardoMogg e5dc894
add tracer
ricardoMogg a948c6e
fix metadata
ricardoMogg b777f12
remove meta from console to prevent ugly formatted errors
ricardoMogg 78c02e5
import tracer only where fs should be existing
ricardoMogg 107bca2
add fs config on next.config
ricardoMogg 8aaad22
remove import for Tracer type
ricardoMogg d41d3d6
add fs config on next.config
ricardoMogg e1ce814
import os path and fs dynamically
ricardoMogg 3ce4d35
update config
ricardoMogg 88a2db9
update config
ricardoMogg 3134919
remove tracer
ricardoMogg 53d9f25
last try on tracer
ricardoMogg c79b852
remove tracer
ricardoMogg 6d5df57
stringify logger
ricardoMogg beef823
add test for client and server side render
ricardoMogg 223100d
remove test loggers
ricardoMogg 40953cf
remove test logs
ricardoMogg 7e63215
remove unneeded logs
ricardoMogg 7f7e309
stop double nil checking for currentSpan
ricardoMogg ba57c93
make logger more readble
ricardoMogg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly here
currentSpan?.context()?.toSpanId()
? if context() is null or undefined we'll get an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context() shouldn't be nil, since it is part of the definition of the object itself