-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L(-2) Config / Command-line work #622
Conversation
…t were unintentionally attributed to the first function
Various fixes for edoc Reviewed-by: reiddraper
Note: this is not quite finished, do not review yet. |
Ready for review. |
@lordnull is this something you could take? |
[print_ip_and_maybe_port(Int), print_ip_and_maybe_port(Ext)]) | ||
|| {Int, Ext} <- riak_repl_ring:get_nat_map(Ring)]. | ||
[print_ip_and_maybe_port(Int), print_ip_and_maybe_port(Ext)]) | ||
|| {Int, Ext} <- riak_repl_ring:get_nat_map(Ring)]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere else the remainder of a list comprehension is indented farther than the start, yet here it's the opposite. It's rather jarring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's aligned with the opening paren of io:format()
. Honestly this is probably just what indent-buffer
gave me.
With the cuttlefish and riak_ee pulls, the r_t tests pass, and manual poking of the cli interface is favorable. The eunit tests for repl do not, primarily the 'riak_repl_schema_tests' do not. |
Also, @javajolt reviewed basho/cuttlefish#166, so that should no longer cause build errors. |
Eunit tests now pass, so looks good from here. |
👍 d980e1b r=lordnull |
L(-2) Config / Command-line work Reviewed-by: seancribbs
Ugh, failing because cuttlefish is pinned to a tag deep in bitcask. Fixing. |
L(-2) Config / Command-line work Reviewed-by: seancribbs
@borshop: retry |
@seancribbs anything left to do on cfish/repl integration other than making unit tests pass? release notes? |
@borshop: retry |
@borshop retry Without a colon - WHY U SAY IT IS BAD? |
@jonmeredith @lordnull Do not merge this yet, I have lots of fixes for CLI inconsistencies. |
Problem: transient failures of aae, such as trees not yet built or locks not being aquired, would cause an aae fullsync process to exit abnormally. This could happen several times in a row, creating log spam. Resolution: the concept of soft_exit. A soft_exit is a message sent from a soon to be exiting process to a soft_linked process. The exiting process would then exit normally, while any soft_linked processes could handle the soft_exit message in a similar fashion as an exit message. This would indicate an exit reason that should be handled, but not bad enough to have the system logger know about it. The soft_exit message sent from the aae worker to the fscoordinator is as simple as `{soft_exit, pid(), term()}'. The current implementation is not generic. There can only one soft_link to the aae, and there's no general mechanism to use soft_link's or soft_exits elsewhere in the code base. Sorry. Another change rolled into this is consistent use of a #partition_info record in the fscoordinator, and error tracking the fscoordinator's state. By swapping to useing a single data structure in the partition queue, whereis waiting list, and purgatory queues it makes it easier to understand the fscordinator (as there is less code modify structures). This is a forward port of the fix done for 1.4. Conflicts favor existing code where it does not directly effect the fix. Conflicts: Makefile rebar.config src/riak_repl2_fssource.erl src/riak_repl2_rtq_proxy.erl src/riak_repl_aae_source.erl test/riak_core_cluster_mgr_tests.erl
@seancribbs what is the list of improvements that you were hoping to add here? |
* `standard_error` group leader cannot be used because it is not forwarded to the RPC caller. * Fix newlines around top-level usage and V2 warnings
These settings were extracted from the replication code, but have not been vetted or necessarily named properly. Many of them are slated to be removed or changed for future versions of riak_repl. To promote a setting to the main schema, one should write documentation and tests to cover the setting.
deprecation/upgrade warnings
6c58063
to
979237f
Compare
Closing so this can be reopened against develop. |
Tasks:
riak_repl_console
, simplifyingriak-repl
scriptRequired PRs:
cuttlefish:warn/1
used in translationsRelated PRs: