L(-2) Config / Command-line work #660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `standard_error` group leader cannot be used because it is not forwarded to the RPC caller. * Fix newlines around top-level usage and V2 warnings
These settings were extracted from the replication code, but have not been vetted or necessarily named properly. Many of them are slated to be removed or changed for future versions of riak_repl. To promote a setting to the main schema, one should write documentation and tests to cover the setting.
deprecation/upgrade warnings
seancribbs
added a commit
to basho/clique
that referenced
this pull request
Mar 11, 2015
This was missed when the function form of usage was created, resulting in the 'clique' module having a narrower spec than the 'clique_usage' module. Prompted by basho/riak_repl#660.
* Register the CLI commands on app startup * Ensure the v2 usage information is registered * Wrap/rewrite "modes" usage * Log the command input and upgrade information to debug before executing * Normalize some output locations to avoid clique output function_clause errors * Return 'nomatch' on the empty command in v2 dispatch * Separate 'clustername' commands into 'show' and 'set' for consistency. * Basic cuttlefish datatypes don't allow "lists", this is a feature of cuttlefish_generator. Restricted the broken types and added TODO. * Corrected a lot of usage strings. * Fixed command upgrades that were poorly matching. * Fixed reversed logic in nat-map add|delete upgrade. * In cases where there was some potentially empty output (e.g. clusters, connections, realtime|fullsync start), pattern-matched the empty list so we can output informative text instead of nothing. * Fixed table-headers on connections and nat-map show. * Fixed some case_clause errors resulting from calls to ring_trans. * Used clique:print instead of io:format in callback that sets fullsync limit configs.
priv/riak_repl.schema
Outdated
| {datatype, {enum, [true, false]}}, | ||
| {default, true} | ||
| %% @doc Whether to initiate a fullsync on initial connection from a | ||
| %% sink cluster. |
There was a problem hiding this comment.
Wouldn't this be "from a source cluster"?
There was a problem hiding this comment.
I am not sure. Do sinks connect to sources or the other way around?
There was a problem hiding this comment.
Sources open the tcp socket to listening sinks.
|
Running the associated riak_test (basho/riak_test#686) fails for me: Running replication2 fails as the console commands have changed, though that's likely more a comment on the r_t pull. Do we want to update those tests at the same time as the console test? |
|
@lordnull Yeah, I need to update the riak_test. Sorry for the delay. |
|
I need more time to analyze and test this change but it's essential for us to get advanced.config out of all riak_ee installations. |
nickelization
force-pushed
the
develop
branch
from
a8fbe0c
to
a8682dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements cuttlefish schemas and new command-line interface based on clique.
See RIAK-1425 and RIAK-1125.
NB: Currently incomplete, but reopening the rebased version of #622.