Treat annotations on inner classes as if on outer #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the behaviour before 8c5954b, and is a behaviour we want to preserve (at least until we have a way of expressing desires more explicitly here). Concretely, this means that things like `-java-annotation-to-attribute=com.example.annotation.FlakyTest=flaky=True` will allow inner annotated classes to affect the generation of targets, rather than ignoring their annotations.
illicitonion
force-pushed
the
annotations-on-inner-classes
branch
from
8bb6073
to
963c565
Compare
stevebarrau
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the behaviour before 8c5954b, and is a behaviour we want to preserve (at least until we have a way of expressing desires more explicitly here).
Concretely, this means that things like
-java-annotation-to-attribute=com.example.annotation.FlakyTest=flaky=Truewill allow inner annotated classes to affect the generation of targets, rather than ignoring their annotations.