Don't ignore the return value of runfiles.merge_all() #3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm running into an issue where data dependencies of C/C++ libraries don't end up being placed in the input roots of Go based tests that depend on these libraries via cgo. It turns out that this is caused by emit_archive() not properly merging runfiles from all GoArchive dependencies. I tried to make a small reproduction case of this under tests/core/cgo, but for the life of me I can't seem to reproduce this. Maybe this can only be observed when cross compiling or using custom C++ toolchains?
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/bazel-starlib
that referenced
this pull request
Apr 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://github.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3861 - Update toolchains_llvm URL and hash by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3864 - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://github.com/Strum355) in [bazelbuild/rules_go#3863 - Make exec cfg check for `//go` stricter by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3867 - Fixes the Bazel CI error by [@​sgowroji](https://github.com/sgowroji) in [bazelbuild/rules_go#3869 - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3866 - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://github.com/mattyclarkson) in [bazelbuild/rules_go#3872 - fix sdk download for common execution platforms by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3874 - Bump Go version to 1.21.8 by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3880 - Update README.rst to point to correct GH release tags by [@​dcarney](https://github.com/dcarney) in [bazelbuild/rules_go#3881 - Update bzlmod.md fix typo by [@​mmrath](https://github.com/mmrath) in [bazelbuild/rules_go#3882 - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://github.com/hauserx) in [bazelbuild/rules_go#3885 - gopackagesdriver: move and simplify test by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3856 - Support Go version schema change since 1.21 by [@​baizhenyu](https://github.com/baizhenyu) in [bazelbuild/rules_go#3891 - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3893 - Revert "improving logging for subcommand failure ([#​3824](https://github.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3892 - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://github.com/c-mita) in [bazelbuild/rules_go#3896 - add nogo parsing support for nogo explanations by [@​andyscott](https://github.com/andyscott) in [bazelbuild/rules_go#3899 - \[nogo] match regexp againts relative paths by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3898 - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3903 - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://github.com/spags-lacework) in [bazelbuild/rules_go#3908 - Reformat with buildifier by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3910 - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://github.com/OparinE) in [bazelbuild/rules_go#3916 - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3911 - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://github.com/EdSchouten) in [bazelbuild/rules_go#3918 - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3909 - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3920 - prepare rules_go v 0.47 by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3923 #### New Contributors - [@​Strum355](https://github.com/Strum355) made their first contribution in [bazelbuild/rules_go#3863 - [@​sgowroji](https://github.com/sgowroji) made their first contribution in [bazelbuild/rules_go#3869 - [@​mattyclarkson](https://github.com/mattyclarkson) made their first contribution in [bazelbuild/rules_go#3872 - [@​scaiper](https://github.com/scaiper) made their first contribution in [bazelbuild/rules_go#3874 - [@​dcarney](https://github.com/dcarney) made their first contribution in [bazelbuild/rules_go#3881 - [@​mmrath](https://github.com/mmrath) made their first contribution in [bazelbuild/rules_go#3882 - [@​hauserx](https://github.com/hauserx) made their first contribution in [bazelbuild/rules_go#3885 - [@​baizhenyu](https://github.com/baizhenyu) made their first contribution in [bazelbuild/rules_go#3891 - [@​c-mita](https://github.com/c-mita) made their first contribution in [bazelbuild/rules_go#3896 - [@​spags-lacework](https://github.com/spags-lacework) made their first contribution in [bazelbuild/rules_go#3908 - [@​OparinE](https://github.com/OparinE) made their first contribution in [bazelbuild/rules_go#3916 **Full Changelog**: bazelbuild/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
added a commit
to kreempuff/rules_unreal_engine
that referenced
this pull request
Apr 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://github.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3861 - Update toolchains_llvm URL and hash by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3864 - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://github.com/Strum355) in [bazelbuild/rules_go#3863 - Make exec cfg check for `//go` stricter by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3867 - Fixes the Bazel CI error by [@​sgowroji](https://github.com/sgowroji) in [bazelbuild/rules_go#3869 - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3866 - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://github.com/mattyclarkson) in [bazelbuild/rules_go#3872 - fix sdk download for common execution platforms by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3874 - Bump Go version to 1.21.8 by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3880 - Update README.rst to point to correct GH release tags by [@​dcarney](https://github.com/dcarney) in [bazelbuild/rules_go#3881 - Update bzlmod.md fix typo by [@​mmrath](https://github.com/mmrath) in [bazelbuild/rules_go#3882 - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://github.com/hauserx) in [bazelbuild/rules_go#3885 - gopackagesdriver: move and simplify test by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3856 - Support Go version schema change since 1.21 by [@​baizhenyu](https://github.com/baizhenyu) in [bazelbuild/rules_go#3891 - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3893 - Revert "improving logging for subcommand failure ([#​3824](https://github.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3892 - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://github.com/c-mita) in [bazelbuild/rules_go#3896 - add nogo parsing support for nogo explanations by [@​andyscott](https://github.com/andyscott) in [bazelbuild/rules_go#3899 - \[nogo] match regexp againts relative paths by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3898 - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3903 - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://github.com/spags-lacework) in [bazelbuild/rules_go#3908 - Reformat with buildifier by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3910 - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://github.com/OparinE) in [bazelbuild/rules_go#3916 - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3911 - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://github.com/EdSchouten) in [bazelbuild/rules_go#3918 - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3909 - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3920 - prepare rules_go v 0.47 by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3923 #### New Contributors - [@​Strum355](https://github.com/Strum355) made their first contribution in [bazelbuild/rules_go#3863 - [@​sgowroji](https://github.com/sgowroji) made their first contribution in [bazelbuild/rules_go#3869 - [@​mattyclarkson](https://github.com/mattyclarkson) made their first contribution in [bazelbuild/rules_go#3872 - [@​scaiper](https://github.com/scaiper) made their first contribution in [bazelbuild/rules_go#3874 - [@​dcarney](https://github.com/dcarney) made their first contribution in [bazelbuild/rules_go#3881 - [@​mmrath](https://github.com/mmrath) made their first contribution in [bazelbuild/rules_go#3882 - [@​hauserx](https://github.com/hauserx) made their first contribution in [bazelbuild/rules_go#3885 - [@​baizhenyu](https://github.com/baizhenyu) made their first contribution in [bazelbuild/rules_go#3891 - [@​c-mita](https://github.com/c-mita) made their first contribution in [bazelbuild/rules_go#3896 - [@​spags-lacework](https://github.com/spags-lacework) made their first contribution in [bazelbuild/rules_go#3908 - [@​OparinE](https://github.com/OparinE) made their first contribution in [bazelbuild/rules_go#3916 **Full Changelog**: bazelbuild/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
trunk-io bot
pushed a commit
to ride-app/payments-service
that referenced
this pull request
Apr 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://github.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3861 - Update toolchains_llvm URL and hash by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3864 - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://github.com/Strum355) in [bazelbuild/rules_go#3863 - Make exec cfg check for `//go` stricter by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3867 - Fixes the Bazel CI error by [@​sgowroji](https://github.com/sgowroji) in [bazelbuild/rules_go#3869 - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3866 - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://github.com/mattyclarkson) in [bazelbuild/rules_go#3872 - fix sdk download for common execution platforms by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3874 - Bump Go version to 1.21.8 by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3880 - Update README.rst to point to correct GH release tags by [@​dcarney](https://github.com/dcarney) in [bazelbuild/rules_go#3881 - Update bzlmod.md fix typo by [@​mmrath](https://github.com/mmrath) in [bazelbuild/rules_go#3882 - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://github.com/hauserx) in [bazelbuild/rules_go#3885 - gopackagesdriver: move and simplify test by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3856 - Support Go version schema change since 1.21 by [@​baizhenyu](https://github.com/baizhenyu) in [bazelbuild/rules_go#3891 - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3893 - Revert "improving logging for subcommand failure ([#​3824](https://github.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3892 - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://github.com/c-mita) in [bazelbuild/rules_go#3896 - add nogo parsing support for nogo explanations by [@​andyscott](https://github.com/andyscott) in [bazelbuild/rules_go#3899 - \[nogo] match regexp againts relative paths by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3898 - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3903 - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://github.com/spags-lacework) in [bazelbuild/rules_go#3908 - Reformat with buildifier by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3910 - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://github.com/OparinE) in [bazelbuild/rules_go#3916 - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3911 - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://github.com/EdSchouten) in [bazelbuild/rules_go#3918 - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3909 - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3920 - prepare rules_go v 0.47 by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3923 #### New Contributors - [@​Strum355](https://github.com/Strum355) made their first contribution in [bazelbuild/rules_go#3863 - [@​sgowroji](https://github.com/sgowroji) made their first contribution in [bazelbuild/rules_go#3869 - [@​mattyclarkson](https://github.com/mattyclarkson) made their first contribution in [bazelbuild/rules_go#3872 - [@​scaiper](https://github.com/scaiper) made their first contribution in [bazelbuild/rules_go#3874 - [@​dcarney](https://github.com/dcarney) made their first contribution in [bazelbuild/rules_go#3881 - [@​mmrath](https://github.com/mmrath) made their first contribution in [bazelbuild/rules_go#3882 - [@​hauserx](https://github.com/hauserx) made their first contribution in [bazelbuild/rules_go#3885 - [@​baizhenyu](https://github.com/baizhenyu) made their first contribution in [bazelbuild/rules_go#3891 - [@​c-mita](https://github.com/c-mita) made their first contribution in [bazelbuild/rules_go#3896 - [@​spags-lacework](https://github.com/spags-lacework) made their first contribution in [bazelbuild/rules_go#3908 - [@​OparinE](https://github.com/OparinE) made their first contribution in [bazelbuild/rules_go#3916 **Full Changelog**: bazelbuild/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/payments-service). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 24, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://github.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3861 - Update toolchains_llvm URL and hash by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3864 - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://github.com/Strum355) in [bazelbuild/rules_go#3863 - Make exec cfg check for `//go` stricter by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3867 - Fixes the Bazel CI error by [@​sgowroji](https://github.com/sgowroji) in [bazelbuild/rules_go#3869 - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3866 - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://github.com/mattyclarkson) in [bazelbuild/rules_go#3872 - fix sdk download for common execution platforms by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3874 - Bump Go version to 1.21.8 by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3880 - Update README.rst to point to correct GH release tags by [@​dcarney](https://github.com/dcarney) in [bazelbuild/rules_go#3881 - Update bzlmod.md fix typo by [@​mmrath](https://github.com/mmrath) in [bazelbuild/rules_go#3882 - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://github.com/hauserx) in [bazelbuild/rules_go#3885 - gopackagesdriver: move and simplify test by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3856 - Support Go version schema change since 1.21 by [@​baizhenyu](https://github.com/baizhenyu) in [bazelbuild/rules_go#3891 - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3893 - Revert "improving logging for subcommand failure ([#​3824](https://github.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3892 - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://github.com/c-mita) in [bazelbuild/rules_go#3896 - add nogo parsing support for nogo explanations by [@​andyscott](https://github.com/andyscott) in [bazelbuild/rules_go#3899 - \[nogo] match regexp againts relative paths by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3898 - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3903 - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://github.com/spags-lacework) in [bazelbuild/rules_go#3908 - Reformat with buildifier by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3910 - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://github.com/OparinE) in [bazelbuild/rules_go#3916 - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3911 - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://github.com/EdSchouten) in [bazelbuild/rules_go#3918 - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3909 - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3920 - prepare rules_go v 0.47 by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3923 #### New Contributors - [@​Strum355](https://github.com/Strum355) made their first contribution in [bazelbuild/rules_go#3863 - [@​sgowroji](https://github.com/sgowroji) made their first contribution in [bazelbuild/rules_go#3869 - [@​mattyclarkson](https://github.com/mattyclarkson) made their first contribution in [bazelbuild/rules_go#3872 - [@​scaiper](https://github.com/scaiper) made their first contribution in [bazelbuild/rules_go#3874 - [@​dcarney](https://github.com/dcarney) made their first contribution in [bazelbuild/rules_go#3881 - [@​mmrath](https://github.com/mmrath) made their first contribution in [bazelbuild/rules_go#3882 - [@​hauserx](https://github.com/hauserx) made their first contribution in [bazelbuild/rules_go#3885 - [@​baizhenyu](https://github.com/baizhenyu) made their first contribution in [bazelbuild/rules_go#3891 - [@​c-mita](https://github.com/c-mita) made their first contribution in [bazelbuild/rules_go#3896 - [@​spags-lacework](https://github.com/spags-lacework) made their first contribution in [bazelbuild/rules_go#3908 - [@​OparinE](https://github.com/OparinE) made their first contribution in [bazelbuild/rules_go#3916 **Full Changelog**: bazelbuild/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
fmeum
pushed a commit
to bazel-contrib/toolchains_llvm
that referenced
this pull request
May 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | minor | `v0.46.0` -> `v0.47.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.47.0`](https://github.com/bazelbuild/rules_go/releases/tag/v0.47.0) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.46.0...v0.47.0) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "af47f30e9cbd70ae34e49866e201b3f77069abb111183f2c0297e7e74ba6bbc0", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.0/rules_go-v0.47.0.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - Add Bazel version matrix to BCR `presubmit.yml` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3861 - Update toolchains_llvm URL and hash by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3864 - pass correct (non `"main"`) importpath to nogo for `main` package by [@​Strum355](https://github.com/Strum355) in [bazelbuild/rules_go#3863 - Make exec cfg check for `//go` stricter by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3867 - Fixes the Bazel CI error by [@​sgowroji](https://github.com/sgowroji) in [bazelbuild/rules_go#3869 - \[go_library] add .x file to declared output files in DefaultInfo by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3866 - Remove Latin-1 workaround on Bazel 6.4.0+ by [@​mattyclarkson](https://github.com/mattyclarkson) in [bazelbuild/rules_go#3872 - fix sdk download for common execution platforms by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3874 - Bump Go version to 1.21.8 by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3880 - Update README.rst to point to correct GH release tags by [@​dcarney](https://github.com/dcarney) in [bazelbuild/rules_go#3881 - Update bzlmod.md fix typo by [@​mmrath](https://github.com/mmrath) in [bazelbuild/rules_go#3882 - Cleanup temp dirs in GoToolchainBinaryBuild by [@​hauserx](https://github.com/hauserx) in [bazelbuild/rules_go#3885 - gopackagesdriver: move and simplify test by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3856 - Support Go version schema change since 1.21 by [@​baizhenyu](https://github.com/baizhenyu) in [bazelbuild/rules_go#3891 - gopackagesdriver: fix version check with Bazel development versions by [@​jayconrod](https://github.com/jayconrod) in [bazelbuild/rules_go#3893 - Revert "improving logging for subcommand failure ([#​3824](https://github.com/bazelbuild/rules_go/issues/3824))" by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3892 - Replace instances of to_json() method with json.encode(..) by [@​c-mita](https://github.com/c-mita) in [bazelbuild/rules_go#3896 - add nogo parsing support for nogo explanations by [@​andyscott](https://github.com/andyscott) in [bazelbuild/rules_go#3899 - \[nogo] match regexp againts relative paths by [@​scaiper](https://github.com/scaiper) in [bazelbuild/rules_go#3898 - Add `bazel_features` transitive `.bzl`s to `bzl_library` targets by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3903 - Add //go/private:polyfill_bazel_features.bzl to sources. by [@​spags-lacework](https://github.com/spags-lacework) in [bazelbuild/rules_go#3908 - Reformat with buildifier by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3910 - GoLink action. Use -extar <ar path> if cc_toolchain provides ar path by [@​OparinE](https://github.com/OparinE) in [bazelbuild/rules_go#3916 - Mark `go_sdk` extension as `reproducible` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3911 - Don't ignore the return value of runfiles.merge_all() by [@​EdSchouten](https://github.com/EdSchouten) in [bazelbuild/rules_go#3918 - Use Gazelle's `go_env` in `@rules_go//go` by [@​fmeum](https://github.com/fmeum) in [bazelbuild/rules_go#3909 - Setting test.timeout according to TEST_TIMEOUT by [@​linzhp](https://github.com/linzhp) in [bazelbuild/rules_go#3920 - prepare rules_go v 0.47 by [@​tyler-french](https://github.com/tyler-french) in [bazelbuild/rules_go#3923 #### New Contributors - [@​Strum355](https://github.com/Strum355) made their first contribution in [bazelbuild/rules_go#3863 - [@​sgowroji](https://github.com/sgowroji) made their first contribution in [bazelbuild/rules_go#3869 - [@​mattyclarkson](https://github.com/mattyclarkson) made their first contribution in [bazelbuild/rules_go#3872 - [@​scaiper](https://github.com/scaiper) made their first contribution in [bazelbuild/rules_go#3874 - [@​dcarney](https://github.com/dcarney) made their first contribution in [bazelbuild/rules_go#3881 - [@​mmrath](https://github.com/mmrath) made their first contribution in [bazelbuild/rules_go#3882 - [@​hauserx](https://github.com/hauserx) made their first contribution in [bazelbuild/rules_go#3885 - [@​baizhenyu](https://github.com/baizhenyu) made their first contribution in [bazelbuild/rules_go#3891 - [@​c-mita](https://github.com/c-mita) made their first contribution in [bazelbuild/rules_go#3896 - [@​spags-lacework](https://github.com/spags-lacework) made their first contribution in [bazelbuild/rules_go#3908 - [@​OparinE](https://github.com/OparinE) made their first contribution in [bazelbuild/rules_go#3916 **Full Changelog**: bazelbuild/rules_go@v0.46.0...v0.47.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
I'm running into an issue where data dependencies of C/C++ libraries don't end up being placed in the input roots of Go based tests that depend on these libraries via cgo. It turns out that this is caused by emit_archive() not properly merging runfiles from all GoArchive dependencies.
I tried to make a small reproduction case of this under tests/core/cgo, but for the life of me I can't seem to reproduce this purely within the confines of io_bazel_rules_go. Maybe this can only be observed when cross compiling or using custom C++ toolchains?
Which issues(s) does this PR fix?
Couldn't find any.
Other notes for review