Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore the return value of runfiles.merge_all() #3918

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Don't ignore the return value of runfiles.merge_all() #3918

merged 1 commit into from
Apr 11, 2024

Commits on Apr 11, 2024

  1. Don't ignore the return value of runfiles.merge_all() 

    I'm running into an issue where data dependencies of C/C++ libraries
don't end up being placed in the input roots of Go based tests that
depend on these libraries via cgo. It turns out that this is caused by
emit_archive() not properly merging runfiles from all GoArchive
dependencies.

I tried to make a small reproduction case of this under tests/core/cgo,
but for the life of me I can't seem to reproduce this. Maybe this can
only be observed when cross compiling or using custom C++ toolchains?
    @EdSchouten
    EdSchouten committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    70a0f85 View commit details
    Browse the repository at this point in the history