Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency typescript to v5 #169

Merged
merged 5 commits into from
Sep 22, 2023
Merged

chore(deps): update dependency typescript to v5 #169

merged 5 commits into from
Sep 22, 2023

Conversation

bcgov-devops
Copy link
Contributor

@bcgov-devops bcgov-devops commented Aug 11, 2023 •
edited by github-actions bot
Loading

This PR contains the following updates:

Package Type Update Change
typescript (source) devDependencies major ^4.9.3 -> ^5.0.0

Release Notes

Microsoft/TypeScript (typescript)

v5.1.6: TypeScript 5.1.6

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on npm

v5.1.5: TypeScript 5.1.5

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.1.3: TypeScript 5.1.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.4: TypeScript 5.0.4

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.3: TypeScript 5.0.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.0.2: TypeScript 5.0

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@bcgov-devops
Copy link
Contributor Author

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: backend/package-lock.json
/usr/local/bin/npm: line 4: .: filename argument required
.: usage: . filename [arguments]
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @nestjs/schematics@9.0.4
npm ERR! Found: typescript@5.1.6
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"^5.0.0" from the root project
npm ERR!   peer typescript@">3.6.0" from fork-ts-checker-webpack-plugin@8.0.0
npm ERR!   node_modules/fork-ts-checker-webpack-plugin
npm ERR!     fork-ts-checker-webpack-plugin@"8.0.0" from @nestjs/cli@10.0.3
npm ERR!     node_modules/@nestjs/cli
npm ERR!       @nestjs/cli@"^10.0.0" from the root project
npm ERR!   4 more (ts-api-utils, ts-jest, ts-loader, ts-node)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"^4.3.5" from @nestjs/schematics@9.0.4
npm ERR! node_modules/@nestjs/schematics
npm ERR!   dev @nestjs/schematics@"^9.0.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: typescript@4.9.5
npm ERR! node_modules/typescript
npm ERR!   peer typescript@"^4.3.5" from @nestjs/schematics@9.0.4
npm ERR!   node_modules/@nestjs/schematics
npm ERR!     dev @nestjs/schematics@"^9.0.4" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2023-08-11T19_22_06_212Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2023-08-11T19_22_06_212Z-debug-0.log

@github-actions github-actions bot added dependencies Pull requests that update a dependency file ignore-for-release labels Aug 11, 2023
@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited
Loading

Current changelog

Bug Fixes

Features

mamartinezmejia
mamartinezmejia requested changes Aug 12, 2023
View reviewed changes
Copy link
Collaborator

@mamartinezmejia mamartinezmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TypeScript version doesn't work with the current @nestjs/schematics version

@bcgov-devops
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@mamartinezmejia mamartinezmejia temporarily deployed to dev September 22, 2023 23:04 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev September 22, 2023 23:05 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia temporarily deployed to dev September 22, 2023 23:14 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mamartinezmejia mamartinezmejia temporarily deployed to dev September 22, 2023 23:15 — with GitHub Actions Inactive
@mamartinezmejia mamartinezmejia merged commit 5198ac9 into main Sep 22, 2023
11 checks passed
@mamartinezmejia mamartinezmejia deleted the renovate/typescript-5.x branch September 22, 2023 23:29
@mamartinezmejia mamartinezmejia temporarily deployed to dev September 22, 2023 23:29 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamartinezmejia mamartinezmejia mamartinezmejia approved these changes

@paulushcgcj paulushcgcj Awaiting requested review from paulushcgcj paulushcgcj is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ignore-for-release source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcgov-devops @mamartinezmejia @renovate-bot @paulushcgcj