Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - re-enable tests on apple silicon #7400

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - re-enable tests on apple silicon #7400

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • The future is now! Rust 1.67 was released with the fix

@mockersf mockersf added O-MacOS Specific to the MacOS (Apple) desktop operating system C-Testing A change that impacts how we test Bevy or how users test their apps A-Time Involves time keeping and reporting labels Jan 28, 2023
@mockersf
Copy link
Member Author

thanks @maniwani!

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 28, 2023
@mockersf
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 28, 2023
@mockersf
re-enable tests on apple silicon (#7400)
bfafa78 
# Objective

- Fixes #6687

## Solution

- The future is now! Rust 1.67 was released with the fix
@bors
Copy link
Contributor

bors bot commented Jan 28, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title re-enable tests on apple silicon [Merged by Bors] - re-enable tests on apple silicon Jan 28, 2023
@bors bors bot closed this Jan 28, 2023
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
re-enable tests on apple silicon (bevyengine#7400)
fd414a9 
# Objective

- Fixes bevyengine#6687

## Solution

- The future is now! Rust 1.67 was released with the fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@djeedai djeedai djeedai approved these changes

Assignees
No one assigned
Labels
A-Time Involves time keeping and reporting C-Testing A change that impacts how we test Bevy or how users test their apps O-MacOS Specific to the MacOS (Apple) desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(in the future) re-enable Time tests on apple m1
3 participants
@mockersf @hymm @djeedai