Add capability to parse and check user-given bases mask (demux_reads … #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Generally looks good, we need a tweak for the CI and minor changes needed to code. |
holtgrewe
reviewed
Feb 1, 2019
holtgrewe
reviewed
Feb 1, 2019
holtgrewe
reviewed
Feb 1, 2019
@holtgrewe Is there a better way than adding |
|
@messersc bandit should only be tweaked for tests |
|
@messersc |
As I understand it, it is only possible to either skip a class of tests or to exclude files/directories. But it is currently not possible to only disable a test ( |
messersc
force-pushed
the
feature/bases_mask
branch
from
b44f8c3
to
2768d2a
Compare
|
OK, fine. |
|
Please make sure to squash and use a rebase commit. |
- Take user-configure bases mask from flowcell (demux_reads) - Check for consistency with planned reads - Translate into bases mask for bcl2fastq2 if necessary
messersc
force-pushed
the
feature/bases_mask
branch
from
cddfb49
to
1d2a0ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…from web) for bcl2fastq2 and picard