Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map to UMLS semantic types #7

Closed
cmungall opened this issue Jan 10, 2018 · 7 comments
Closed

Map to UMLS semantic types #7

cmungall opened this issue Jan 10, 2018 · 7 comments
Assignees

Comments

@cmungall
Copy link
Collaborator

cmungall commented Jan 10, 2018

See also NCATS-Tangerine/beacon-aggregator#15 and NCATS-Tangerine/translator-knowledge-beacon#15

@cmungall
Copy link
Collaborator Author

@RichardBruskiewich has already done a lot of this, e.g. 9951bee

@RichardBruskiewich
Copy link
Contributor

The UMLS semantic "Groups" (e.g. GENE, CHEM, DISO, etc.) are posted to the Biolink Model, but I've not yet put in the finer grained codes (e.g. 'aapp' etc. see https://metamap.nlm.nih.gov/Docs/SemanticTypes_2013AA.txt). I guess I could tackle these soon when I'm bored with straight computer software development :-)

cmungall pushed a commit that referenced this issue Mar 19, 2018
@cmungall
Copy link
Collaborator Author

the goal isn't to include all of these. We're calling this done when existing entity types in BLM have a mapping

hsolbrig added a commit that referenced this issue Jul 9, 2018
Renamed RDF --> OWL and ontogen to owlgen
@cmungall
Copy link
Collaborator Author

Is this completed?

@RichardBruskiewich
Copy link
Contributor

RichardBruskiewich commented Mar 21, 2019

Ancient issue, long neglected... I note that the "semantic types" were note added. They are more fine grained than the UMLS semantic groups. I vaguely seem to recall that MediKanren may have been using them, but don't know if that is still the case.

I can strive to add them into Biolink today.

I'll use the CURIE xmlns prefix UMLSST (ST == Semantic Type). I'll obviously be selective on which ones to include since the scope of types is a superset of what Biolink covers.

For good measure(?), I can add the "codes" as UMLSSC:

e.g.

T083	geoa	Geographic Area	GEOG	Geographic Areas

will have mappings:

UMLSSG:GEOG
UMLSST:geoa
UMLSSC:T083

Also, I assume that Biolink categories can be "one-to-many" UMLS semantic types, where the Biolink model does not make fine grained distinction between the UMLS semantic types of a given UMLS Semantic Group,

For example, the UMLS Semantic Group "DEVI" doesn't seem to have any is_a: device categories in the model, so I'll aggregate all the DEVI semantic types as mappings to the one 'device' category in Biolink.

@RichardBruskiewich
Copy link
Contributor

RichardBruskiewich commented Mar 21, 2019

@cmungall are biolink category mappings supposed to be one-to-one? The reason I ask is that we have two UMLSSG:GENE mappings: one to the Biolink category "genomic entity" and the other (obviously) to "gene".

I wonder if this presents any practical difficulties with software using the Biolink model? I suspect perhaps...

The UMLS semantic types under the Semantic Group "GENE" are:

T028	gngm	Gene or Genome	GENE	Genes & Molecular Sequences
T085	mosq	Molecular Sequence	GENE	Genes & Molecular Sequences
T086	nusq	Nucleotide Sequence	GENE	Genes & Molecular Sequences
T087	amas	Amino Acid Sequence	GENE	Genes & Molecular Sequences
T088	crbs	Carbohydrate Sequence	GENE	Genes & Molecular Sequences

Which are (carelessly) broad in Biolink scope.

@RichardBruskiewich
Copy link
Contributor

Completed the above task (I think...) and issued a pull request: #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants