[PM-11123] Service layer for Notification Center #4375
Triggered via pull request
September 12, 2024 08:44
Status
Success
Total duration
5m 34s
Artifacts
–
test.yml
on: pull_request
Check for test secrets
0s
Run tests
5m 11s
Annotations
10 warnings
Run tests:
src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L11
'ProviderInitiateDeleteModel.WebVaultUrl' hides inherited member 'BaseMailModel.WebVaultUrl'. Use the new keyword if hiding was intended.
|
Run tests:
src/Core/Models/Mail/Provider/ProviderInitiateDeleteModel.cs#L14
'ProviderInitiateDeleteModel.SiteName' hides inherited member 'BaseMailModel.SiteName'. Use the new keyword if hiding was intended.
|
Run tests:
src/Core/AdminConsole/OrganizationFeatures/OrganizationUsers/UpdateOrganizationUserCommand.cs#L118
Possible null reference argument for parameter 'collections' in 'Task IOrganizationUserRepository.ReplaceAsync(OrganizationUser obj, IEnumerable<CollectionAccessSelection> collections)'.
|
Run tests:
src/Core/NotificationCenter/Authorization/NotificationStatusAuthorizationHandler.cs#L18
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
Run tests:
src/Core/Billing/Services/Implementations/PaymentHistoryService.cs#L14
Parameter 'logger' is unread.
|
Run tests:
src/Infrastructure.Dapper/AdminConsole/Repositories/OrganizationRepository.cs#L180
Possible null reference return.
|
Run tests:
src/Api/AdminConsole/Public/Models/MemberBaseModel.cs#L67
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
Run tests:
src/Admin/AdminConsole/Models/OrganizationEditModel.cs#L146
'OrganizationEditModel.UseSecretsManager' hides inherited member 'OrganizationViewModel.UseSecretsManager'. Use the new keyword if hiding was intended.
|
Run tests:
src/Admin/Views/Users/_ViewInformation.cshtml#L17
'IUserService.TwoFactorIsEnabledAsync(ITwoFactorProvidersUser)' is obsolete: 'Use ITwoFactorIsEnabledQuery instead.'
|
Run tests:
src/Admin/Views/Users/Index.cshtml#L87
'IUserService.TwoFactorIsEnabledAsync(ITwoFactorProvidersUser)' is obsolete: 'Use ITwoFactorIsEnabledQuery instead.'
|