Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/friend view calendar fetch #149

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Refactor/friend view calendar fetch #149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b80c33a
[refactor] ์•ˆ์“ฐ๋Š” FriendCalendarUseCase ์‚ญ์ œ
wickedRun Dec 12, 2022
fc78443
[refactor] FriendCalendarUseCase๊ฐ€ ์•„๋‹Œ CalendarUseCase๋กœ protocol ๋ณ€๊ฒฝ ๋ฐ ๊ตฌํ˜„
wickedRun Dec 12, 2022
2bd9661
[refactor] QuestRepository์˜ ํ•œ๋‹ฌ ๋ฐ์ดํ„ฐ ๊ฐ€์ ธ์˜ค๋Š” ๋ฉ”์†Œ๋“œ ๋ฆฌํ„ด ํƒ€์ž… ๋ณ€๊ฒฝ
wickedRun Dec 12, 2022
f5a90fb
[refactor] DefaultQuestRepository์˜ ํ•œ๋‹ฌ ๋ฐ์ดํ„ฐ ๊ฐ€์ ธ์˜ค๋Š” ๋ฉ”์†Œ๋“œ ๊ตฌํ˜„
wickedRun Dec 12, 2022
d084913
[refactor] FriendCalendarUseCase๋ฅผ CalendarUseCase๋กœ ๋ณ€๊ฒฝ
wickedRun Dec 12, 2022
6c81402
[refactor] drag ์ œ์Šค์ณ ๊ตฌํ˜„
wickedRun Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DailyQuest/DailyQuest/Application/DIContainer/BrowseSceneDIContainer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ final class BrowseSceneDIContainer {
return DefaultFriendUseCase(questsRepository: makeQuestsRepository())
}

func makeFriendCalendarUseCase(with user: User) -> FriendCalendarUseCase {
func makeFriendCalendarUseCase(with user: User) -> CalendarUseCase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ถ€๋ถ„ ์ฐธ๊ณ ํ•ด์„œ, DI Container ๋ณ€๊ฒฝ๋˜๋Š” ๋ถ€๋ถ„์„ ์ฒ˜๋ฆฌํ•ด์•ผ๊ฒ ์Šต๋‹ˆ๋‹ค. ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

return DefaultFriendCalendarUseCase(user: user, questsRepository: makeQuestsRepository())
}

Expand Down
4 changes: 2 additions & 2 deletions DailyQuest/DailyQuest/Presentation/Common/ViewModel/FriendViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ import RxCocoa
final class FriendViewModel {
private(set) var user: User
private let friendQuestUseCase: FriendQuestUseCase
private let friendCalendarUseCase: FriendCalendarUseCase
private let friendCalendarUseCase: CalendarUseCase

init(user: User,
friendQuestUseCase: FriendQuestUseCase,
friendCalendarUseCase: FriendCalendarUseCase)
friendCalendarUseCase: CalendarUseCase)
{
self.user = user
self.friendQuestUseCase = friendQuestUseCase
Expand Down