Skip to content
This repository has been archived by the owner on Mar 6, 2019. It is now read-only.

Confirmations #106

Merged
merged 14 commits into from
Jan 18, 2019
Merged

Confirmations #106

merged 14 commits into from
Jan 18, 2019

Commits on Jan 15, 2019

  1. wip

    @tmancey
    tmancey committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    023df37 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. Resolved cpplint issues

    @tmancey
    tmancey committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    7f8dac3 View commit details
    Browse the repository at this point in the history

  2. Resolved mock build error

    @tmancey
    tmancey committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    3df7e60 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Resolved issue with uninitialized vectors

    @tmancey
    tmancey committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    bc92cb9 View commit details
    Browse the repository at this point in the history

  2. Resolved issue with last page classification not being retained after… 

    … browser restart
    @tmancey
    tmancey committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    cf33999 View commit details
    Browse the repository at this point in the history

  3. Improved error handling

    @tmancey
    tmancey committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    9cef400 View commit details
    Browse the repository at this point in the history

  4. Improved error handling

    @tmancey
    tmancey committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    b180a1c View commit details
    Browse the repository at this point in the history

  5. Improved error handling

    @tmancey
    tmancey committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    953939d View commit details
    Browse the repository at this point in the history

  6. Improved error handling

    @tmancey
    tmancey committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    aba1185 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. various cosmetic edits 

    README - include synopsis of stand-alone build instructions
event_type_load.h - include tab classification in structure
ads_impl.{h,cc} -
- move load event to classifier method to get accurate log entries
- add GetRegion method for use with brave-core/ui
- more logging in classifier method
- make adsPerDay a no-op until design/product decides what to do with that feature
- more logging for onTimer to see why it fires
bundle.cc - fix hierarchy typo
mock_ads_client.cc - s/result/status to avoid double definition issue

note that client_->GetLastPageClassification is no longer needed
    @mrose17
    mrose17 committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    ac4e12c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wip' of https://github.com/brave-intl/bat-native-ads in… 

    …to wip
    @mrose17
    mrose17 committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    5b20a25 View commit details
    Browse the repository at this point in the history

  3. Resolved compiler warnings

    @tmancey
    tmancey committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    9ae4db5 View commit details
    Browse the repository at this point in the history

  4. Fixed cpplint issues

    @tmancey
    tmancey committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    1305684 View commit details
    Browse the repository at this point in the history

  5. Exposed GetRegion

    @tmancey
    tmancey committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    e2ab988 View commit details
    Browse the repository at this point in the history