"Show Brave suggested sites in autocomplete suggestions" should default to off

[ryanml]

The preference that drives the behavior described in #9572 for ref code addition to default to opt-in only

Test Plan

1. Install Brave with a clean profile
2. Navigate to brave://settings, scroll to Appearance

Expected Result

3. Show Brave suggested sites in autocomplete suggestions setting defaults to off

Actual Result

3. Show Brave suggested sites in autocomplete suggestions setting defaults to on

[kjozwiak]

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.9.80 Chromium: 81.0.4044.138 (Official Build) (64-bit)
--- | ---
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1909 (Build 18363.836)

• ensured that Show Brave suggested sites in autocomplete suggestions under brave://settings/appearance is disabled by default on a clean profile
• ensured that Brave suggested sites are not being displayed in the omnibox when Show Brave suggested sites in autocomplete suggestions is disabled
• ensured that Brave suggested sites are being displayed in the omnibox when Show Brave suggested sites in autocomplete suggestions has been enabled
• ensured that Brave suggested sites was disabled after upgrading from 1.9.76 CR: 81.0.4044.138 --> 1.9.80 CR: 81.0.4044.138
  • ensured that Brave suggested sites are not being displayed under the omnibox
  • ensured that Brave suggested sites are being displayed under the omnibox once Show Brave suggested sites in autocomplete suggestions is enabled via brave://settings/appearance after upgrading
• ensured that disabling Show Brave suggested sites in autocomplete suggestions under brave://settings/appearance before upgrading to 1.9.80 CR: 81.0.4044.138 retains the change.

---

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave | 1.9.80 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

• ensured that Show Brave suggested sites in autocomplete suggestions under brave://settings/appearance is disabled by default on a clean profile
• ensured that Brave suggested sites are not being displayed in the omnibox when Show Brave suggested sites in autocomplete suggestions is disabled
• ensured that Brave suggested sites are being displayed in the omnibox when Show Brave suggested sites in autocomplete suggestions has been enabled
• ensured that Brave suggested sites was disabled after upgrading from 1.9.76 CR: 81.0.4044.138 --> 1.9.80 CR: 81.0.4044.138
  • ensured that Brave suggested sites are not being displayed under the omnibox
  • ensured that Brave suggested sites are being displayed under the omnibox once Show Brave suggested sites in autocomplete suggestions is enabled via brave://settings/appearance after upgrading
• ensured that disabling Show Brave suggested sites in autocomplete suggestions under brave://settings/appearance before upgrading to 1.9.80 CR: 81.0.4044.138 retains the change.

---

Verification passed on

Brave	1.9.80 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Ubuntu 18.04 LTS

• ensured that Show Brave suggested sites in autocomplete suggestions under brave://settings/appearance is disabled by default on a clean profile
• ensured that Brave suggested sites are not being displayed in the omnibox when Show Brave suggested sites in autocomplete suggestions is disabled
• ensured that Brave suggested sites are being displayed in the omnibox when Show Brave suggested sites in autocomplete suggestions has been enabled
• ensured that Brave suggested sites was disabled after upgrading from 1.9.76 CR: 81.0.4044.138 --> 1.9.80 CR: 81.0.4044.138
  • ensured that Brave suggested sites are not being displayed under the omnibox
  • ensured that Brave suggested sites are being displayed under the omnibox once Show Brave suggested sites in autocomplete suggestions is enabled via brave://settings/appearance after upgrading
• ensured that disabling Show Brave suggested sites in autocomplete suggestions under brave://settings/appearance before upgrading to 1.9.80 CR: 81.0.4044.138 retains the change.

---

Verification passed on Samsung Galaxy J3 version 5.1.1 running BraveModernarm 1.9.80.apk

• Verified that Show Suggested sites in autocomplete under Settings->Advance->Privacy is disabled by default in a clean profile
• Verified that Brave suggested sites are not displayed in Omnibox when Show Suggested sites in autocomplete is disabled
• Verified that Brave suggested sites are displayed in Omnibox when Show Suggested sites in autocomplete is enabled
• Verified that Show Suggested sites in autocomplete under Settings->Advance->Privacy is disabled when brave is upgraded from 1.9.79 to 1.9.80
• Verified that, after upgrade from 1.9.79 to 1.9.80, Brave suggested sites are not displayed in Omnibox as Show Suggested sites in autocomplete is disabled in 1.9.80
• Verified that, after upgrade from 1.9.79 to 1.9.80, Show Suggested sites in autocomplete option can be enabled in 1.9.80 and Brave suggested sites are displayed in Omnibox

---

Verification passed on BraveModernarm v1.9.80 on Samsung Galaxy Tab S5e (Android 9.0)

• Verified that Show Suggested sites in autocomplete under Settings->Advance->Privacy is disabled by default in a clean profile
• Verified that Brave suggested sites are not displayed in Omnibox when Show Suggested sites in autocomplete is disabled
• Verified that Brave suggested sites are displayed in Omnibox when Show Suggested sites in autocomplete is enabled
• Verified that Show Suggested sites in autocomplete under Settings->Advance->Privacy is disabled when brave is upgraded from 1.9.79 to 1.9.80
• Verified that, after upgrade from 1.9.79 to 1.9.80, Brave suggested sites are not displayed in Omnibox as Show Suggested sites in autocomplete is disabled in 1.9.80
• Verified that, after upgrade from 1.9.79 to 1.9.80, Show Suggested sites in autocomplete option can be enabled in 1.9.80 and Brave suggested sites are displayed in Omnibox

---

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.9.80 BraveModernx86.apk

• Verified that Show Suggested sites in autocomplete under Settings->Advance->Privacy is disabled by default in a clean profile
• Verified that Brave suggested sites are not displayed in Omnibox when Show Suggested sites in autocomplete is disabled
• Verified that Brave suggested sites are displayed in Omnibox when Show Suggested sites in autocomplete is enabled
• Verified that Show Suggested sites in autocomplete under Settings->Advance->Privacy is disabled when brave is upgraded from 1.9.79 to 1.9.80
• Verified that, after upgrade from 1.9.79 to 1.9.80, Brave suggested sites are not displayed in Omnibox as Show Suggested sites in autocomplete is disabled in 1.9.80
• Verified that, after upgrade from 1.9.79 to 1.9.80, Show Suggested sites in autocomplete option can be enabled in 1.9.80 and Brave suggested sites are displayed in Omnibox