Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disables Brave suggested sites by default (uplift to 1.10.x) #5764

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Disables Brave suggested sites by default (uplift to 1.10.x) #5764

merged 1 commit into from
Jun 8, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Jun 7, 2020 •
edited by kjozwiak
Loading

Uplift of #5761
Fixes brave/brave-browser#10131

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@ryanml
Merge pull request #5761 from brave/fix-10131
a29e1a7 
Disables Brave suggested sites by default
@ryanml ryanml added this to the 1.10.x - Release milestone Jun 7, 2020
@ryanml ryanml requested a review from a team June 7, 2020 06:43
@ryanml ryanml self-assigned this Jun 7, 2020
@bsclifton bsclifton changed the title Disables Brave suggested sites by default (1.10) Disables Brave suggested sites by default (uplift to 1.10.x) Jun 8, 2020
@bsclifton
Copy link
Member

Has been tested on Nightly by @srirambv 👍

bsclifton
bsclifton approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 0a24b29 into 1.10.x Jun 8, 2020
@bsclifton bsclifton deleted the opt-in-ref-1.10 branch June 8, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@ryanml ryanml

Labels
feature/settings
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @bsclifton