Follow up of #4599 - Person 1 profile keeps coming back after being deleted

[GeetaSarvadnya]

Description

Follow up of #4599 - Person 1 profile keeps coming back after being deleted

Steps to Reproduce

1. Follow the @bsclifton's steps via Person 1 profile keeps coming back after being deleted - Cannot delete the 'Default' user profile #4599 (comment)

Step 11 - Local State JSON at profile root (%USERPROFILE%\AppData\local\BraveSoftware\Brave-Browser-Beta\User Data\Local State)

In this step 11, the Default folder got deleted from the profile folder "profiles_deleted": [ "C:\\Users\\DELL\\AppData\\Local\\BraveSoftware\\Brave-Browser-Beta\\User Data\\Default"

"profile": {
    "info_cache": {
      "Profile 1": {
        "active_time": 1677155310.972828,
        "avatar_icon": "chrome://theme/IDR_PROFILE_AVATAR_26",
        "background_apps": false,
        "default_avatar_fill_color": -4790029,
        "default_avatar_stroke_color": -15172462,
        "force_signin_profile_locked": false,
        "gaia_id": "",
        "is_consented_primary_account": false,
        "is_ephemeral": false,
        "is_using_default_avatar": true,
        "is_using_default_name": true,
        "managed_user_id": "",
        "metrics_bucket_index": 2,
        "name": "Profile 2",
        "profile_highlight_color": -4790029,
        "shortcut_name": "Profile 2",
        "signin.with_credential_provider": false,
        "user_name": ""
      }
    },
    "last_active_profiles": [
      "Profile 1"
    ],
    "last_used": "Profile 1",
    "metrics": {
      "next_bucket_index": 3
    },
    "picker_shown": true,
    "profile_counts_reported": "13321628883501143",
    "profiles_created": 2
  },
  "profile_network_context_service": {
    "http_cache_finch_experiment_groups": "None None None None"
  },
  "profiles": {
    "profiles_deleted": [
      "C:\\Users\\DELL\\AppData\\Local\\BraveSoftware\\Brave-Browser-Beta\\User Data\\Default"
    ]
  },

After step 13 - Local State JSON at profile root (%USERPROFILE%\AppData\local\BraveSoftware\Brave-Browser-Beta\User Data\Local State)
In this step the Default folder appeared again in profile folder C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser-Beta\User Data hence the profile deleted block is empty in "Local_State" "profiles_deleted": []

"profile": {
    "info_cache": {
      "Default": {
        "active_time": 1677171986.650275,
        "avatar_icon": "chrome://theme/IDR_PROFILE_AVATAR_26",
        "background_apps": false,
        "force_signin_profile_locked": false,
        "gaia_id": "",
        "is_consented_primary_account": false,
        "is_ephemeral": false,
        "is_using_default_avatar": true,
        "is_using_default_name": true,
        "managed_user_id": "",
        "metrics_bucket_index": 3,
        "name": "Profile 1",
        "shortcut_name": "Profile 1",
        "signin.with_credential_provider": false,
        "user_name": ""
      },
      "Profile 1": {
        "active_time": 1677171857.712762,
        "avatar_icon": "chrome://theme/IDR_PROFILE_AVATAR_26",
        "background_apps": false,
        "default_avatar_fill_color": -205879,
        "default_avatar_stroke_color": -4437750,
        "force_signin_profile_locked": false,
        "gaia_id": "",
        "is_consented_primary_account": false,
        "is_ephemeral": false,
        "is_using_default_avatar": true,
        "is_using_default_name": true,
        "managed_user_id": "",
        "metrics_bucket_index": 2,
        "name": "Profile 2",
        "profile_highlight_color": -205879,
        "shortcut_name": "Profile 2",
        "signin.with_credential_provider": false,
        "user_name": ""
      }
    },
    "last_active_profiles": [
      "Default",
      "Profile 1"
    ],
    "last_used": "Profile 1",
    "metrics": {
      "next_bucket_index": 4
    },
    "picker_shown": true,
    "profile_counts_reported": "13321645449336260",
    "profiles_created": 2
  },
  "profile_network_context_service": {
    "http_cache_finch_experiment_groups": "None None None None"
  },
  "profiles": {
    "profiles_deleted": []
  },

Actual result:

Person 1 profile keeps coming back after being deleted

https://drive.google.com/file/d/1P-iE7d4q3VjXdKexBesxHVoeOyZ1nxtr/view?usp=sharing

Expected result:

Person 1 should not come back.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision	46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS	Windows 10 Version 21H2 (Build 19044.2604)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @bsclifton @DJAndries

[DJAndries]

@GeetaSarvadnya The only way I was able to reproduce this was by exiting via the main menu in step 4. If I close the default profile window before closing the new profile window in step 4, I'm not able to reproduce this. Can you confirm this is the case? This is definitely a bug, but probably not the typical/practical way to delete the default profile.

[GeetaSarvadnya]

@DJAndries: After adding Profile 2, if you close Profile 1 or Profile 2 window and exit brave via 3 dot menu will reproduce the issue 100 %.

After adding Profile 2, if you close both Profile 1 or Profile 2 window by clicking on the close (x) on main windows will NOT reproduce the issue. As you mentioned exit brave via 3 dot menu or settings menu will reproduce the issue 100%, when there are multiple profile windows opened users will always use 3 dot menu to exit all the brave instances. So, in this case also it should be working.

Steps which reproduced 100 % on windows 10 x64 :

1. Clean profile 1.49.108
2. Click on 3 dot menu or settings menu and create a new Profile 2
3. Make sure Profile 1 and Profile 2 windows are opened
4. Exit brave via 3 dot menu in Profile 1 or Profile 2 window
5. Relaunch brave
6. Ensured that the Profile manager modal popup window is opened which lists the Profile 1 and Profile 2
7. Delete Profile 1 in Profile manager modal popup window
8. Ensured Profile 1 is deleted in Profile manager modal popup window
9. Close the Profile manager by clicking on X button on modal popup window
10. Relaunch brave
11. Person 1 profile keeps coming back after being deleted

[MadhaviSeelam]

Reproduced in Win 11 x64 using STR from #28728 (comment)

Brave | 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 21H2 (Build 22000.1574)