Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person 1 profile keeps coming back after being deleted - Cannot delete the 'Default' user profile #4599

Closed
maurelian opened this issue May 24, 2019 · 84 comments · Fixed by brave/brave-core#16026

Comments

@maurelian
Copy link

maurelian commented May 24, 2019

Test plan

See brave/brave-core#13929

Description

  • Recently a new profile named 'Person 1' started appearing in the menu. I cannot delete this account, and it is the default option when switching profiles, so it's quite annoying.

Steps to Reproduce

Approach 1:

  1. See undesired profile in menu named Person 1.
  2. Go to "Manage People", click on 3-dots button for Person 1, click 'Delete this person'
  3. Exit and restart brave.
  4. Person 1 is back

Approach 2:

  1. See undesired profile in menu named Person 1.
  2. Open brave://version, look for Profile Path, which is ~/.config/BraveSoftware/Brave-Browser/Default
  3. Delete that directory.
  4. Restart Brave.
  5. Person 1 is back. The directory is back.

Actual result:

image

Expected result:

Person 1 does not come back.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave | 0.62.51 Chromium: 73.0.3683.103 (Official Build)unknown (64-bit)
Revision | e82a658d8159cabbd4938c1660f9bb00b4a82a23-refs/branch-heads/3683@{#902}
OS | Linux

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?

No.

  • Does the issue resolve itself when disabling Brave Rewards?

Doubtful.

  • Is the issue reproducible on the latest version of Chrome?

No. There is no unwanted profile when I open Chrome version 74.0.3729.131 (Official Build) (64-bit)

@Corgi
Copy link

Corgi commented Jun 4, 2019

I also have this issue. I use Brave on a Windows machine and a Mac, and this issue only manifests on the Windows install.

@rebron rebron added the OS/Linux label Jun 7, 2019
@rebron
Copy link
Collaborator

rebron commented Jun 7, 2019

cc: @kjozwiak To see if this is an issue on Windows.

Also need to update reproducible steps.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 7, 2019
@srirambv
Copy link
Contributor

srirambv commented Jun 7, 2019

Here's the proper reproducible steps

  1. Start a clean profile
  2. Click on people icon and click on Manage people
  3. Add a new person in Manage people window
  4. Click on Person 2 window and click on people icon, lists Person 1 in the list
  5. In manage people window, click on 3 dots of Person 1 and delete it
  6. Open Person 2window and click on people icon, still lists Person 1 there. Clicking that will create a new Person 1 window

@kjozwiak
Copy link
Member

@srirambv can you reproduce the above on Win as well or this strictly occurring on Linux only?

@srirambv
Copy link
Contributor

Yet to check on Windows.

@srirambv
Copy link
Contributor

This seems to be a problem on Linux only. Verified the same steps from #4599 (comment) on Windows and it doesn't show Person 1 option in people menu drop down after its removed.

@sumit0k
Copy link

sumit0k commented Jul 15, 2019

Happening to me on
macOS v10.14.5

and

Brave desktop
Version 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)

@theAeon
Copy link

theAeon commented Jul 16, 2019

Happening on Win here

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1903 (Build 18362.239)

Others have reproduced the issues here:
https://www.reddit.com/r/brave_browser/comments/btoibq/how_do_i_stop_person_1_profile_from_creating

@GeetaSarvadnya
Copy link

This issue is Reproducible on Windows 10 x64

Brave 0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

@aapit
Copy link

aapit commented Aug 6, 2019

This error is still occurring in Brave on Linux.

Brave version: 0.67.123
OS: Ubuntu 19.04

@georgewitteman
Copy link

I have this issue on macOS 10.14.6 and Brave Version 0.68.132 Chromium: 76.0.3809.132 (Official Build) (64-bit)

@yatobjection
Copy link

I have the same issue.

OS: Windows 10
Brave: Version 0.68.140 Chromium: 77.0.3865.90 (Build officiel) (64 bits)

@iranmarcius
Copy link

Happening here:

Brave | 0.68.142 Chromium: 77.0.3865.90 (Versão oficial) 64 bits
Revision| 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
SO | Windows 10 OS Version 1903 (Build 18362.356)

@iranmarcius
Copy link

I thought it would happen only when I deleted "person 1" profile, as a a consequence of Brave recreating and selecting the default profile automatically.

But it's not it. From time to time, even with a pre-existent "person 1" profile Brave keeps selecting when open. It's not a huge problem, of course, but it's a litte bit anoying.

@luangjokaj
Copy link

I have the same issue. When I installed Brave, I created +2 new accounts, then deleted the first "original" account. After restarting Brave "Person 1" always keeps coming back.

Brave | 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision | 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS | macOS Version 10.15 (Build 19A583)

@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Reproduced using scenario from #4599 (comment)

@garroch
Copy link

garroch commented Nov 7, 2019

Reproduced on Windows 10, also using scenario from #4599 (comment)

Version: 0.70.122 Chromium: 78.0.3904.87 (Official Build) (64-bit)
OS: Windows 10 Home v.1903 build 18362.418

@gl-santos
Copy link

gl-santos commented Nov 13, 2019

This error is still happening in Version 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)

There is a workaround:

  1. Go to your .config folder (something like /home/youruser/.config/BraveSoftware/Brave-Browser);
  2. Backup your Default, Profile 1, Profile 2, Profile 3... folders somewhere else (if anything goes wrong you can restore to your original state);
  3. Close all Brave windows, delete the contents of Default folder and move the contents of any other profile to the Default folder. Then you can delete empty folder;
  4. Restart Brave.

@garroch
Copy link

garroch commented Nov 14, 2019

I had previously reported this issue on Win10 / Brave 0.70.122, but this appears to be resolved in 1.0.0.

I completely uninstalled Brave 0.70.122 (selecting the option to erase all website data on uninstall), then reinstalled a fresh copy of 1.0.0.

@chizmw
Copy link

chizmw commented Jan 8, 2020

Seeing the issue on:

OS macOS Catalina 10.15.2
Brave Version 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)

@Jammerlee
Copy link

Also having this issue on Windows 10 x64

@alexanderlarsen
Copy link

I have this issue as well.

Win 10 x64
Brave: Version 1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)

@spylogsster
Copy link

@DJAndries @bridiver can we take a look again on it? thanks

@omegadefender
Copy link

Looks like this is going to be resolved soon, but for Windows users... don't delete the contents of the Default folder at C:\Users{urUserName}\AppData\Local\BraveSoftware\Brave-Browser\User Data just copy-paste in the contents from the folder of one of your other profiles, and then delete the original folder of the profile you just copied into default. You will need to rename profile1 to whatever you called the profile you copied in, but you will see all your bookmarks etc have been copied.

@brendon-wong
Copy link

I am still experiencing this issue on Brave "Version 1.47.186 Chromium: 109.0.5414.119 (Official Build) (arm64)" on MacOS 13.1. I am have been regularly deleting Profile 1 and it keep reappearing on restart.

@MeerKatDev
Copy link

Same version, same issue

@DJAndries
Copy link
Collaborator

@brendon-wong @MeerKatDev Hey, the issue is fixed in 1.49.x, which is scheduled to be released on March 7.

@brendon-wong
Copy link

Great! I was a bit thrown off by the discussion being closed but figured that might be the case given it was added to the 1.49.x - Nightly milestone. Will report back after updating post-March 7th!

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 17, 2023
@stephendonner
Copy link

stephendonner commented Feb 17, 2023

Verification PASSED using

Brave 1.49.106 Chromium: 110.0.5481.104 (Official Build) beta (x86_64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 11.7.4 (Build 20G1120)

First, reproduced easily on Windows 10 (1st try) using 1.48.167, using @bsclifton's concise steps, resulting in Profile 1 appearing:

image

Tested and confirmed the following scenarios, without seeing Profile 1 or similar, appearing

Shared Steps:

  1. installed 1.49.106
  2. launched Brave (this creates Profile 1 which is fine at this step)
  3. created the specified # of profiles, either/both Bubba 1 and Bubba 2
  4. restarted
  5. deleted Profile 1 (auto-created on launch in step 2)
  6. restarted
  7. checked to see if the deleted Profile 1 has now returned
  8. (remaining steps only for single-profile case: additionally selected Create a New Profile from the top-level app menu)
  9. typed Blah and saved
  10. confirmed only Blah and the correct Bubba(s) -- and only those -- were present

In addition to the below, focus-tested around profile creation/management 👍

Case 1: create a new profile, restart, delete, restart - PASSED

Bubba removed Profile 1 profile manager
Screen Shot 2023-02-21 at 2 34 26 PM Screen Shot 2023-02-21 at 2 36 18 PM Screen Shot 2023-02-21 at 2 38 49 PM

Case 2: create two new profiles, restart, delete one, restart - PASSED

Bubbas 1&2 removed Profile 1 after restart
Screen Shot 2023-02-21 at 3 05 56 PM Screen Shot 2023-02-21 at 3 06 05 PM Screen Shot 2023-02-21 at 3 06 12 PM

Case 3: create two new profiles, restart, delete both, restart - PASSED

Bubbas 1&2 removed Profile 1 & Bubba 1 profile manager
Screen Shot 2023-02-21 at 3 12 39 PM Screen Shot 2023-02-21 at 3 13 21 PM Screen Shot 2023-02-21 at 3 13 50 PM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 20, 2023

Verification PASSED on

Brave | 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (64-bit)
-- | --
Revision | 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS | Windows 10 Version 21H2 (Build 19044.2604)

Reproduced the issue on 1.48.167 using @bsclifton's STR
The issue is reproducible in one case on 1.49.x, logged a follow up issue #28728

Clean profile:

Create a new profile 2 and delete default profile 1_PASSED
  1. Clean profile 1.49.x
  2. Click on the 3 dot menu
  3. Select the Create a new profile menu option and add a Profile 2
  4. Click on the Profile 1 window
  5. Click on the Manage profile settings in the Profile 1 window
  6. Ensure that Profile 1 is listed
  7. Click on the 3 dots (more actions) and delete the Profile 1
  8. Restart the browser
  9. Open Profile 2 and ensured that the Profile 1 is deleted completely and it's not returned back
  10. Open brave://settings/manageProfile and ensure that Profile 1 is not listed

https://drive.google.com/file/d/19V35ZPmEtq-nQXz_B1RnLH_Rb830_QmT/view?usp=sharing

Create profile 2 and profile 3 and delete profile 1_PASSED
  1. Clean profile 1.49.x
  2. Click on the 3 dot menu
  3. Select the Create a new profile menu option and add 2 new profiles Profile 2 and Profile 3
  4. Click on the Profile 3 window
  5. Click on the Manage profile settings in the Profile 3 window
  6. Ensure that Profile 1 is listed
  7. Click on the 3 dots (more actions) and delete the Profile 1
  8. Open Profile 2 and Profile 3 and ensure that Profile 1 is deleted completely from the profiles (2 and 3)
  9. Restart the browser
  10. Open Profile 2 and Profile 3 and ensure that Profile 1 is deleted completely from the profiles (2 and 3)
  11. Open brave://settings/manageProfile in Profile 2 and Profile 3 and ensure that Profile 1 is not listed

https://drive.google.com/file/d/1fP42SZm--dr_5yBuww5W6Ix4IJnTOTdo/view?usp=share_link

Edit the default profile name and restart the browser and verify the default profile after restart_PASSED
  1. Clean profile 1.49.x
  2. Click on the 3 dot menu
  3. Select the Create a new profile menu option and add a new profile Profile 2`
  4. Click on the Manage profile settings in the Profile 2 window
  5. Ensure that Profile 1 is listed
  6. Click on the 3 dots (more actions) and edit and rename Profile 1 to Profile 3
  7. Open the Profile 2 and Profile 3 windows and ensured that the Profile 1 is NOT listed
  8. Restart the browser
  9. Open the Profile 2 and Profile 3 windows and ensured that the Profile 1 is NOT listed

Upgrade profile:

Install 1.48.x and upgrade the profile to 1.49.x and add a new profile 2 and delete default profile 1_PASSED
  1. Install 1.48.x
  2. Upgrade the profile to 1.49.x
  3. Add a new profile 2 via the 3 dot menu
  4. Delete the default profile 1 via manage profile
  5. Open brave://settings/manageProfile and ensure that profile 1 is not shown
  6. Add a new profile 3 via the 3 dot menu
  7. Open profile 2 and profile 3 and ensured that the default profile 1 is not listed in the manage profile
Install 1.48.x add a new Profile 2 and delete profile 1 and upgrade profile to 1.49.x_PASSED
  1. Install 1.48.x
  2. Add a new profile 2 via the 3 dot menu
  3. Delete the default profile 1 via manage profile
  4. Upgrade the profile to 1.49.x
  5. Add a new profile 3 via the 3 dot menu
  6. Open profile 2 and profile 3 and ensured that the default profile 1 is not listed in the manage profile
Install 1.48.x add a new Profile 2 and edit profile 1 and upgrade profile to 1.49.x_PASSED
  1. Install 1.48.x
  2. Add a new profile 2 via the 3 dot menu
  3. Edit and rename the default profile 1 to profile 3 via manage profile
  4. Upgrade the profile to 1.49.x
  5. Open profile 2 and ensured that the default profile name is renamed to profile 3 in the manage profile

Additional scenarios

Case 1: Add profile 2, close Profile 1 window, delete profile 1 and relaunch browser_PASSED
  1. Clean profile 1.49.108
  2. Click on 3 dot menu or settings menu and create a new Profile 2
  3. Make sure Profile 1 and Profile 2 windows are opened
  4. Click on the Profile 1 window and close the Profile 1 windows by clicking on the close (x)
  5. Make sure Profile 1 window is closed
  6. Click on the profile manager in Profile 2 and delete the Profile 1
  7. Exit brave via 3 dot menu in Profile 2
  8. Relaunch brave
  9. Profile 1 is deleted completely and it's not returned back after browser reaunch
Case 2: Add profile 2, exit brave via profile 1 or Profile 2, relaunch, delete profile 1, relaunch brave_PASSED
  1. Clean profile 1.49.108
  2. Click on 3 dot menu or settings menu and create a new Profile 2
  3. Make sure Profile 1 and Profile 2 windows are opened
  4. Exit brave via 3 dot menu in Profile 2/Profile 1
  5. Relaunch brave
  6. Delete Profile 1 in Profile manager modal popup window
  7. Ensure Profile 1 is deleted
  8. Click on Profile 2 in Profile manager modal popup window
  9. Exit brave via 3 dot menu in Profile 2
  10. Relaunch brave
  11. Profile 1 is deleted completely and it's not returned back after browser reaunch
Case 3:Add profile 2, close Profile 1,2 by closing the windows, relaunch, delete profile 1, relaunch_PASSED
  1. Clean profile 1.49.108
  2. Click on 3 dot menu or settings menu and create a new Profile 2
  3. Make sure Profile 1 and Profile 2 windows are opened
  4. Click on the Profile 1 window and close the Profile 1 windows by clicking on the close (x)
  5. Click on the Profile 2 window and close the Profile 2 windows by clicking on the close (x)
  6. Relaunch brave
  7. Ensured that the Profile manager modal popup window is opened which lists the Profile 1 and Profile 2
  8. Delete Profile 1 in Profile manager modal popup window
  9. Ensured Profile 1 is deleted in Profile manager modal popup window
  10. Close the Profile manager by clicking on X button on modal popup window
  11. Relaunch brave
  12. Profile 1 is deleted completely and it's not returned back after browser reaunch
Case 4: Add profile 2, exit brave via profile 1 or 2, relaunch, delete profile 1, relaunch_FAILED_Logged #28728
  1. Clean profile 1.49.108
  2. Click on 3 dot menu or settings menu and create a new Profile 2
  3. Make sure Profile 1 and Profile 2 windows are opened
  4. Exit brave via 3 dot menu in Profile 1 or Profile 2 window
  5. Relaunch brave
  6. Ensured that the Profile manager modal popup window is opened which lists the Profile 1 and Profile 2
  7. Delete Profile 1 in Profile manager modal popup window
  8. Ensured Profile 1 is deleted in Profile manager modal popup window
  9. Close the Profile manager by clicking on X button on modal popup window
  10. Relaunch brave
  11. Person 1 profile keeps coming back after being deleted

@bsclifton
Copy link
Member

Get out of here, Person 1! Hopefully we never see you around here again 😛

@btlechowski
Copy link

Verification passed on

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Tested and confirmed the following scenarios, without seeing Profile 1 or similar, appearing

Shared Steps:

  1. installed 1.49.x
  2. launched Brave (this creates Profile 1 which is fine at this step)
  3. created the specified # of profiles, either/both Bubba 1 and Bubba 2
  4. restarted
  5. deleted Profile 1 (auto-created on launch in step 2)
  6. restarted
  7. checked to see if the deleted Profile 1 has now returned
  8. (remaining steps only for single-profile case: additionally selected Create a New Profile from the top-level app menu)
  9. typed Blah and saved
  10. confirmed only Blah and the correct Bubba(s) -- and only those -- were present

In addition to the below, focus-tested around profile creation/management 👍

Case 1: create a new profile, restart, delete, restart - PASSED

image
image

Case 2: create two new profiles, restart, delete one, restart - PASSED

image
image

Case 3: create two new profiles, restart, delete both, restart - PASSED

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment