Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dashboard Settings menu in NTP doesn't support dark theme #5452

Closed
GeetaSarvadnya opened this issue Jul 30, 2019 · 2 comments
Closed

The Dashboard Settings menu in NTP doesn't support dark theme #5452

GeetaSarvadnya opened this issue Jul 30, 2019 · 2 comments
Labels
closed/duplicate Issue has already been reported

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 30, 2019

Description

Found while testing #4523
The Dashboard settings menu in NTP doesn't support dark theme

Steps to Reproduce

  1. Set OS theme as dark
  2. Launch brave 0.68.113
  3. Go to settings and set theme Same as Window
  4. Open NTP
  5. Click on Dashboard Settings menu
  6. Dashboard Settings menu is not changed to Dark it is still white

Actual result:

The Dashboard Settings menu in NTP doesn't support dark theme

image

image

Expected result:

As per the comments mentioned in Design spec #4523 (comment), the dark theme should be supported for Dashboard Settings menu

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa

@imptrx
Copy link

imptrx commented Jul 30, 2019

@GeetaSarvadnya I believe this is a duplicate of #5014. The dark mode work was de-scoped from the original issue(brave/brave-core#2668 (comment)) and is currently being worked on 😃

@kjozwiak
Copy link
Member

Closing & Labelling as Duplicate as per #5452 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

3 participants