Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Background Settings for New Tabs Page #2668

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

imptrx
Copy link
Contributor

@imptrx imptrx commented Jun 12, 2019

Feature: brave/brave-browser#4523
Sister PR to brave/brave-ui#485 which was merged and reverted.
Sister PR to brave/brave-ui#491 (brave-ui)

close brave/brave-browser#4523

Submitter Checklist:

Test Plan:

  • Ensure settings menu pop up properly (toggle)
  • Ensure the background toggles from the menu
  • Clicking outside the settings menu should close it

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@imptrx imptrx self-assigned this Jun 13, 2019
@imptrx imptrx added this to the 0.68.x - Nightly milestone Jun 17, 2019
@imptrx imptrx force-pushed the toggle-background-ntp branch 3 times, most recently from d89101b to 97caf99 Compare June 18, 2019 21:08
@imptrx
Copy link
Contributor Author

imptrx commented Jun 18, 2019

Note: dark mode implementation will be removed from the scope of this PR as there is some additional discussion to be done around that for our web-ui pages

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ nice work!

@petemill
Copy link
Member

Some issues that may be good to solve before this hits release:

  • The new button is not accessible without a mouse or touch. I assume because we're rendering an <a element without an href attribute. It's not tabbable like that. At least I couldn't find a way to open the settings menu with the keyboard.

  • The toggle represents a user preference, but it is being saved to localStorage. Should we want this to be part of Brave Sync (to another device), then it would be more possible if this is a regular chromium preference object. localStorage also prevents surfacing this preference on the Settings page. If we do want any of these options in the future, then we will find it difficult to migrate from localStorage to Preferences, so I would suggest starting with it as a Preference object from the beginning of the feature, otherwise we would have to 'forget' user's settings when we migrate, which would be a bit hostile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to show/hide background images on New Tab Page
3 participants