Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added widevine steps to pipeline #3981

Merged
merged 1 commit into from
Apr 3, 2019
Merged

added widevine steps to pipeline #3981

merged 1 commit into from
Apr 3, 2019

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Apr 3, 2019 •
edited by simonhong
Loading

Close #944

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@mihaiplesa mihaiplesa added this to the 0.65.x - Nightly milestone Apr 3, 2019
@mihaiplesa mihaiplesa self-assigned this Apr 3, 2019
@mihaiplesa mihaiplesa mentioned this pull request Apr 3, 2019
Closed
@mihaiplesa mihaiplesa mentioned this pull request Apr 3, 2019
Closed
16 tasks
bsclifton
bsclifton approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihaiplesa mihaiplesa marked this pull request as ready for review April 3, 2019 20:07
@mihaiplesa mihaiplesa merged commit 2be0ff8 into master Apr 3, 2019
@mihaiplesa mihaiplesa deleted the mplesa-widevine branch April 3, 2019 20:10
@bsclifton bsclifton mentioned this pull request Apr 3, 2019
Closed
@simonhong simonhong mentioned this pull request Apr 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@mihaiplesa mihaiplesa

Labels
None yet
Projects
None yet
Milestone
0.65.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaiplesa @bsclifton