Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign widevine #944

Closed
bbondy opened this issue Sep 4, 2018 · 6 comments · Fixed by brave/brave-core#2158, #4000 or #4853
Closed

Sign widevine #944

bbondy opened this issue Sep 4, 2018 · 6 comments · Fixed by brave/brave-core#2158, #4000 or #4853
Assignees
@mihaiplesa @bsclifton @mbacchi @simonhong
Labels
feature/video OS/macOS OS/Windows plugin/Widevine priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Sep 4, 2018 •
edited by simonhong
Loading

Test plan

  1. Login to Netflix
  2. Play content and verify it works
  3. Find the .sig file and rename it (ex, .sig.bak)
    • C:\Program Files (x86)\BraveSoftware\Brave-Browser-Nightly\Application\version (Windows admin install)
    • C:\Users\XXX\AppData\Local\BraveSoftware\Brave-Browser-Nightly\Application\version (Windows non-admin install)
    • /Applications/Brave Browser Nightly.app/Contents/Frameworks/Brave Browser Nightly Framework.framework/Versions/75.0.68.71/Resources/Brave Browser Nightly Framework.sig (MacOS)
  4. Reloading content in Netflix
  5. Content should no longer work
  6. Back to original sig file name
  7. Reloading content in Netflix
  8. Content should be played

NOTES:

Description

Equivalent to this:
https://github.com/brave/browser-laptop/blob/master/tools/buildInstaller.js#L74
@bbondy bbondy added this to the Releasable builds 0.55.x milestone Sep 4, 2018
@bsclifton bsclifton mentioned this issue Sep 26, 2018
Merged
11 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Sep 26, 2018
@bsclifton
Enable Widevine Host Verification for our build
9124d18 
Will help enable brave/brave-browser#944
bsclifton added a commit to brave/brave-core that referenced this issue Sep 27, 2018
@bsclifton
Properly revert the following PRs only from 0.55.x:
21aea58 
- #507
- #510

When ready to tackle brave/brave-browser#944, we need to revert this commit (which will only be in 0.55.x branch)
bsclifton added a commit to brave/brave-core that referenced this issue Sep 27, 2018
@bsclifton
Properly revert the following PRs:
6926ccb 
- #507
- #510

When ready to tackle brave/brave-browser#944, we need to revert this commit
@bsclifton bsclifton mentioned this issue Sep 27, 2018
Merged
11 tasks
@bsclifton bsclifton self-assigned this Oct 5, 2018
@bbondy bbondy added the QA/Yes label Oct 10, 2018
@bbondy bbondy modified the milestones: 0.55.x, 1.x Backlog Oct 11, 2018
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 11, 2018
@bsclifton bsclifton mentioned this issue Oct 11, 2018
Closed
11 tasks
@mihaiplesa mihaiplesa self-assigned this Oct 19, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@simonhong simonhong self-assigned this Mar 19, 2019
@simonhong simonhong added this to the 0.64.x - Nightly milestone Mar 20, 2019
This was referenced Mar 27, 2019
Merged
Merged
@mihaiplesa
Copy link
Contributor

Adding changes needed for pipeline in #3981

@bsclifton
Copy link
Member

Partially fixed with #3903 and brave/brave-core#2023 ; we'll need #3981 too, as @mihaiplesa called above (then we can close this)

@simonhong
Copy link
Member

@bsclifton @mihaiplesa Yay! 👍

@mihaiplesa mihaiplesa mentioned this issue Apr 3, 2019
Merged
16 tasks
@simonhong
Copy link
Member

VMP related PRs are reverted because Windows PR builders failed for signing.
brave/brave-core#2157
#3993
#3994

@simonhong simonhong reopened this Apr 4, 2019
This was referenced Apr 4, 2019
Merged
Merged
This was referenced Jun 12, 2019
Merged
Merged
@bsclifton bsclifton mentioned this issue Jun 14, 2019
Closed
2 tasks
@bsclifton bsclifton mentioned this issue Jul 29, 2019
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 2, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
  • Verified test plan from description.
    cc @kjozwiak to check on Mojave

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Verification passed on

Brave 0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 7 Service Pack 1 (Build 7601.24494)
  • Verified test plan from description.

When signature is renamed I get an error message:
image

@kjozwiak
Copy link
Member

kjozwiak commented Aug 7, 2019

@bbondy just a quick double check regarding the case under #944 (comment). When you rename Brave Browser Nightly Framework.sig, you need to restart the browser or the content will keep playing even though the file was renamed. Assuming this is expected as the Brave Browser Nightly Framework.sig was already being used when initially launching the browser before renaming.

@simonhong simonhong mentioned this issue Apr 28, 2023
Merged
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihaiplesa mihaiplesa

@bsclifton bsclifton

@mbacchi mbacchi

@simonhong simonhong

Labels
feature/video OS/macOS OS/Windows plugin/Widevine priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
9 participants
@bbondy @mihaiplesa @kjozwiak @bsclifton @rebron @mbacchi @simonhong @LaurenWags @btlechowski