Enable Widevine VMP on MacOS and Windows #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
enable_cdm_host_verification
branch
2 times, most recently
from
e595a9b
to
2e1ce10
Compare
simonhong
force-pushed
the
enable_cdm_host_verification
branch
5 times, most recently
from
9bd374d
to
ef65c7a
Compare
simonhong
force-pushed
the
enable_cdm_host_verification
branch
from
ef65c7a
to
0214901
Compare
simonhong
force-pushed
the
enable_cdm_host_verification
branch
2 times, most recently
from
86421d1
to
4dc1ca1
Compare
Merged
16 tasks
simonhong
force-pushed
the
enable_cdm_host_verification
branch
4 times, most recently
from
bbf2819
to
52a897b
Compare
|
@darkdh Rebased on master |
darkdh
previously approved these changes
Mar 29, 2019
|
I'll not merge this now because this PR makes conflict with C74 and C74 will be merged soon. |
VMP is enabled with official build and all below envs are set. SIGN_WIDEVINE_KEY: private key SIGN_WIDEVINE_CERT: widevine cert SIGN_WIDEVINE_PASSPHRASE: pass for key sig generator should be located in //third_party/widevine/scripts/signature_generator.py
browser signing is removed from `create_dist` target. Instead, build` step will do signing and generate widevine sig file. Then, those signed files and sig files will be used during the `create-dist`. This is because gn python can't use external cryptgraphy module needed by sig generator scripts. So, brave-browser `build` target will use system python for it.
simonhong
force-pushed
the
enable_cdm_host_verification
branch
from
52a897b
to
e1d9144
Compare
|
@darkdh Would you approve again? I rebased this PR on C74. |
bsclifton
reviewed
Apr 3, 2019
There was a problem hiding this comment.
I'm curious why this is failing patching, when CI runs. It uses brave-browser branch enable_cdm_host_verification, which is properly rebased and has the correct Chromium 74 pinned: brave/brave-browser@65f03ec
|
Whoops - RE: the above, it needs brave/brave-browser#3903 (which isn't in |
16 tasks
bsclifton
approved these changes
Apr 3, 2019
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMP is enabled with official build and all below envs are set.
SIGN_WIDEVINE_KEY: private key
SIGN_WIDEVINE_CERT: widevine cert
SIGN_WIDEVINE_PASSPHRASE: pass for key
sig generator should be located in
//third_party/widevine/scripts/signature_generator.py before build starts on buildbot.
Issue brave/brave-browser#944
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Check sig file is in installed folder.
On MacOS, sig file(
Brave Browser Framework.sig) is inBrave Browser.app/Contents/Versions/7x.x.x.x/Widevine Resources.bundle/Contents/Resources/Brave Browser Framework.sigOn Windows, sig files(
brave.exe.sig,chrome.dll.sigandchrome_child.dll.sig) are inC:\Program Files (x86)\BraveSoftware\Brave-Browser-XXX\Application\7x.x.x.x\Check netflix works
Reviewer Checklist: