Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Widevine VMP on MacOS and Windows #2023

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Enable Widevine VMP on MacOS and Windows #2023

merged 2 commits into from
Apr 3, 2019

Commits on Apr 3, 2019

  1. Enable Widevine VMP on MacOS 

    VMP is enabled with official build and all below envs are set.
SIGN_WIDEVINE_KEY: private key
SIGN_WIDEVINE_CERT: widevine cert
SIGN_WIDEVINE_PASSPHRASE: pass for key

sig generator should be located in
//third_party/widevine/scripts/signature_generator.py
    @simonhong
    simonhong committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    6c643e8 View commit details
    Browse the repository at this point in the history

  2. Enable widevine VMP on Windows 

    browser signing is removed from `create_dist` target.
Instead, build` step will do signing and generate widevine sig file.
Then, those signed files and sig files will be used during the
`create-dist`.
This is because gn python can't use external cryptgraphy module needed
by sig generator scripts. So, brave-browser `build` target will use
system python for it.
    @simonhong
    simonhong committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    e1d9144 View commit details
    Browse the repository at this point in the history