Automatically limit unwanted Brave Ads delivery #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
requested review from
kylehickinson,
emerick,
zenparsing,
NejcZdovc and
masparrow
| @@ -11,6 +11,7 @@ @interface BATAdNotification () | |||
| @property (nonatomic, copy) NSString *parentUuid; | |||
| @property (nonatomic, copy) NSString *creativeInstanceID; | |||
| @property (nonatomic, copy) NSString *creativeSetID; | |||
| @property (nonatomic, copy) NSString *campaignID; | |||
There was a problem hiding this comment.
I don't see anything in particular (aside from the change to the ads_service_impl at the top), but is this new property supposed to be used in the client in a specific way?
There was a problem hiding this comment.
Also missing the read-only property definition for this in BATAdsNotification.h
There was a problem hiding this comment.
This new property is not used in the client as of yet
kylehickinson
approved these changes
Mar 24, 2020
tmancey
force-pushed
the
issues/6253
branch
3 times, most recently
from
11cb6ad
to
67d7025
Compare
tmancey
force-pushed
the
issues/6253
branch
3 times, most recently
from
24a229b
to
4b2ee90
Compare
tmancey
requested review from
pes10k
and removed request for
masparrow and
pes10k
tmancey
force-pushed
the
issues/6253
branch
7 times, most recently
from
20d5af8
to
e7b9e43
Compare
tmancey
force-pushed
the
issues/6253
branch
4 times, most recently
from
bad3dda
to
801eec3
Compare
tmancey
added
CI/skip-android
|
CI failed on macOS, restarting macOS |
tmancey
force-pushed
the
issues/6253
branch
2 times, most recently
from
ba42680
to
8b08be2
Compare
tmancey
removed
CI/skip-android
tmancey
force-pushed
the
issues/6253
branch
3 times, most recently
from
3f7c055
to
16b50c3
Compare
tmancey
added
CI/skip-android
|
CI failed on Windows for known test, restarting macOS. macOS failing due to known issue at brave/brave-browser#6515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#6253
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See brave/brave-browser#6253
Reviewer Checklist:
After-merge Checklist:
changes has landed on.