Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't query brave theme id to ThemeHelper::GetDefaultColor() #5712

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 2, 2020

ThemeHelper::GetDefaultColor() doesn't know about brave's theme
properties.

Resolves brave/brave-browser#10055

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.11.x - Nightly milestone Jun 2, 2020
@simonhong simonhong self-assigned this Jun 2, 2020
@simonhong
Copy link
Member Author

I think this PR should be uplifted together with c83 uplift.

ThemeHelper::GetDefaultColor() doesn't know about brave's theme
properties.
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member

Good to merge 👍

@bsclifton bsclifton merged commit 41e2a11 into master Jun 2, 2020
@bsclifton bsclifton deleted the brave_theme_properties branch June 2, 2020 21:17
mkarolin pushed a commit that referenced this pull request Jun 4, 2020
Don't query brave theme id to ThemeHelper::GetDefaultColor()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCHECK failure - FATAL:theme_properties.cc(142)] Check failed: false.
3 participants