Combine rust libs #6408
Merged
Combine rust libs #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
force-pushed
the
combine-rust-libs
branch
from
655227f
to
9f461d9
Compare
warning: unused variable: `origin`
--> /Users/jenkins/jenkins/workspace/pr-brave-browser-combine-rust-libs-ios/src/brave/components/speedreader/rust/lib/src/rewriter_config_builder.rs:40:5
|
40 | origin: &str,
| ^^^^^^ help: consider prefixing with an underscore: `_origin`
|
= note: `#[warn(unused_variables)]` on by default
Compiling speedreader-ffi v0.1.0 (/Users/jenkins/jenkins/workspace/pr-brave-browser-combine-rust-libs-ios/src/brave/components/speedreader/rust/ffi)
Compiling adblock-ffi v0.1.0 (/Users/jenkins/jenkins/workspace/pr-brave-browser-combine-rust-libs-ios/src/brave/vendor/adblock_rust_ffi)
tmancey
reviewed
Aug 15, 2020
| "//base", | ||
| ] | ||
|
|
||
| if (is_mac || is_ios ) { |
There was a problem hiding this comment.
nit: extra space before )
NejcZdovc
approved these changes
Aug 15, 2020
|
This did pass windows at one point, but now I keep getting various errors that seem to be related to windows path length limitations I'm going to merge and see if the problem shows up in nightly which should have a shorter path ( |
32 tasks
rillian
added a commit
that referenced
this pull request
Dec 13, 2021
We were patching the rust cssparser crate to work around an issue with `f64::powf` linking to symbols from the system glibc which couldn't be satisfied by the sysroot the official builds link against. This has since been addressed by having cargo target the same sysroot, I think by #6408, so we can remove the diversion and use the upstream crate which lets us update more easily and benefit from shared audits. Resolves brave/brave-browser#20080
25 tasks
rillian
added a commit
that referenced
this pull request
Jan 26, 2022
We were patching the rust cssparser crate to work around an issue with `f64::powf` linking to symbols from the system glibc which couldn't be satisfied by the sysroot the official builds link against. This has since been addressed by having cargo target the same sysroot, I think by #6408, so we can remove the diversion and use the upstream crate which lets us update more easily and benefit from shared audits. Resolves brave/brave-browser#20080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#6515
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.