Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Made every place of buttons on the navigation bar (backButton, forwar…
Browse files Browse the repository at this point in the history
…dButton, stopButton, reloadButton and homeButton) clickable

Fixes #5679

Auditors: @bradleyrichter

Test Plan:
1. Enable Home Button
2. Open some pages in the same tab to enable backButton and forwardButton
3. Make sure every place of the buttons are clickable
4. Make sure height and width of the buttons remain the same (34x24, 26x24)
5. Make sure stopButton is centered
  • Loading branch information
Suguru Hirahara committed Nov 19, 2016
1 parent 91b1421 commit 214ce2d
Showing 1 changed file with 25 additions and 35 deletions.
60 changes: 25 additions & 35 deletions less/navigationBar.less
Original file line number Diff line number Diff line change
Expand Up @@ -481,19 +481,9 @@

.backButton,
.forwardButton {
width: 20px;
margin-top: 5px;
}

.backButton {
padding-right:4px;
margin-left: 4px;
width: 100%;
}

.forwardButton {
padding-left: 4px;
margin-left: 6px;
}
}

// Navigation bar at the center
Expand Down Expand Up @@ -532,10 +522,10 @@

.extensionButton {
-webkit-app-region: no-drag;
background-size: contain;
height: 17px;
margin: 4px 4px 0 0;
opacity: 0.85;
background-size: contain;
height: 17px;
margin: 4px 4px 0 0;
opacity: 0.85;
}

.braveMenu {
Expand Down Expand Up @@ -581,11 +571,11 @@
width: 26px;
margin-left: -3px;
margin-right: 6px;

&.nav {
margin-left: 4px;
margin-right: 1px;
width: 34px;
margin-left: 4px;
margin-right: 1px;
width: 34px;
}

&:last-child {
Expand All @@ -600,44 +590,44 @@

.backButton,
.forwardButton {
height: 15px;
height: 24px;
width: 30px;
margin-top: 5px;
margin: 0;
}

.backButton {
background: url('../img/toolbar/back_btn.svg') center no-repeat;
margin-left: 4px;
background-size: 15px 15px;
}

.forwardButton {
background: url('../img/toolbar/forward_btn.svg') center no-repeat;
margin-left: 4px;
background-size: 15px 15px;
}

#navigator {
.stopButton,
.reloadButton,
.homeButton {
margin: 0;
padding: 0;
width: 100%;
height: 100%;
}

.stopButton {
background: url('../img/toolbar/stoploading_btn.svg') center no-repeat;
margin: 0 3px 3px 3px;
padding: 0 6px;
height: 12px;
position: relative;
top: 3px;
background-size: 12px 12px;
}

.reloadButton {
background: url('../img/toolbar/reload_btn.svg') center no-repeat;
margin: 0 3px -1px 3px;
padding: 0 4px;
position: relative;
background-size: 15px 15px;
}

.homeButton {
background: url('../img/toolbar/home_btn.svg') center no-repeat;
width: 14px;
height: 13px;
padding: 0 6px;
position: relative;
background-size: 18px 18px;
}

.bookmarkButton {
Expand Down

0 comments on commit 214ce2d

Please sign in to comment.