Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark manager dnd is not working #10936

Closed
NejcZdovc opened this issue Sep 13, 2017 · 0 comments · Fixed by #10937
Closed

Bookmark manager dnd is not working #10936

NejcZdovc opened this issue Sep 13, 2017 · 0 comments · Fixed by #10937
Assignees
@diracdeltas
Labels
feature/bookmarks misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 13, 2017 •
edited by srirambv
Loading

Test plan

  1. go to about:bookmarks, try dragging and dropping some bookmarks. it should work.
  2. drag a tab to change its position. it should work.

Describe the issue you encountered:
DND in bookmark manager is not working. Try dnd bookmark into another folder.

This is was caused by #10589
@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Sep 13, 2017
diracdeltas added a commit that referenced this issue Sep 13, 2017
@diracdeltas
Fix Brave bookmark drag-and-drop
bcc66fe 
fix #10936

Test Plan:
1. go to about:bookmarks, try dragging and dropping some bookmarks. it should work.
2. drag a tab to change its position. it should work.
@diracdeltas diracdeltas mentioned this issue Sep 13, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Sep 13, 2017
@diracdeltas
Fix Brave bookmark drag-and-drop
10f2ebf 
fix #10936

Test Plan:
1. go to about:bookmarks, try dragging and dropping some bookmarks. it should work.
2. drag a tab to change its position. it should work.
NejcZdovc pushed a commit that referenced this issue Sep 14, 2017
@diracdeltas @NejcZdovc
Fix Brave bookmark drag-and-drop
7f2117c 
fix #10936

Test Plan:
1. go to about:bookmarks, try dragging and dropping some bookmarks. it should work.
2. drag a tab to change its position. it should work.
NejcZdovc pushed a commit that referenced this issue Sep 14, 2017
@diracdeltas @NejcZdovc
Fix Brave bookmark drag-and-drop
899e417 
fix #10936

Test Plan:
1. go to about:bookmarks, try dragging and dropping some bookmarks. it should work.
2. drag a tab to change its position. it should work.
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/bookmarks misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

Successfully merging a pull request may close this issue.

Fix Brave bookmark drag-and-drop brave/browser-laptop
5 participants
@diracdeltas @luixxiul @NejcZdovc @srirambv @LaurenWags