Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix Brave bookmark drag-and-drop #10937

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Fix Brave bookmark drag-and-drop #10937

merged 1 commit into from
Sep 14, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Sep 13, 2017

fix #10936

Test Plan:

  1. go to about:bookmarks, try dragging and dropping some bookmarks. it should work.
  2. drag a tab to change its position. it should work.
  3. try detaching and reattaching tabs

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@diracdeltas
Copy link
Member Author

diracdeltas commented Sep 13, 2017

While testing this out, I found a separate DnD issue on master (haven't tested other branches):

  1. show the bookmarks toolbar
  2. try to re-order the bookmarks in the toolbar
  3. this does not trigger a renderer update, so the bookmark order is still the same. however if you trigger a renderer update by bookmarking a new page, the order suddenly changes.

fix #10936

Test Plan:
1. go to about:bookmarks, try dragging and dropping some bookmarks. it should work.
2. drag a tab to change its position. it should work.
@NejcZdovc
Copy link
Contributor

@diracdeltas this is a know issue and it will be fixed with #10325

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried dnd bookmarks and folders in bookmark manager, tried dnd tabs (reordering), tried detaching and reattaching tabs and everything is working correctly

@NejcZdovc NejcZdovc merged commit 5e2cfb3 into master Sep 14, 2017
@NejcZdovc
Copy link
Contributor

master 10f2ebf
0.20.x 7f2117c
0.19.x 899e417

@diracdeltas diracdeltas deleted the fix/10936 branch September 14, 2017 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmark manager dnd is not working
3 participants