Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add lower amount to Brave Payments monthly budget choices #12465

Closed
bradleyrichter opened this issue Jan 2, 2018 · 2 comments
Closed

Add lower amount to Brave Payments monthly budget choices #12465

bradleyrichter opened this issue Jan 2, 2018 · 2 comments
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x Hotfix 11 ...

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jan 2, 2018 •
edited by bsclifton
Loading

Test plan

Original issue description

As a user, I need more options for monthly budget choices to meet my contribution needs.

image
@bradleyrichter bradleyrichter added this to the 0.20.x (Beta Channel) milestone Jan 2, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 3, 2018
@NejcZdovc
Adds lower amount into monhtly budget
bde696f 
Resolves brave#12465

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 3, 2018
@NejcZdovc
Adds lower amount into monhtly budget
767bab7 
Resolves brave#12465

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 3, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 3, 2018
@NejcZdovc
Adds lower amount into monhtly budget
93c4161 
Resolves brave#12465

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Jan 3, 2018
@bsclifton
Merge pull request #12473 from NejcZdovc/hotfix/#12465-amount
8a781e2 
 Adds lower amount into monthly budget
bsclifton added a commit that referenced this issue Jan 3, 2018
@bsclifton
Merge pull request #12473 from NejcZdovc/hotfix/#12465-amount
86fb1d0 
 Adds lower amount into monthly budget
bsclifton added a commit that referenced this issue Jan 3, 2018
@bsclifton
Merge pull request #12473 from NejcZdovc/hotfix/#12465-amount
b3377bc 
 Adds lower amount into monthly budget
@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 Jan 3, 2018
bsclifton added a commit that referenced this issue Jan 3, 2018
@bsclifton
Merge pull request #12473 from NejcZdovc/hotfix/#12465-amount
43f717b 
 Adds lower amount into monthly budget
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 4, 2018
@NejcZdovc
Adds 200 option for monthly budget
c0b8cce 
Resolves brave#12465

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 4, 2018
Closed
10 tasks
@bsclifton bsclifton changed the title Add lower and higher amounts to Brave Payments monthly budget choices Add lower amount to Brave Payments monthly budget choices Jan 4, 2018
This was referenced Jan 4, 2018
Closed
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2018

Verified that the following worked as expected using 0.19.126:

  • ensured that 10 BAT is appearing under the monthly budget
  • ensured that 10 BAT is being listed under the Contribution Statement
  • ensured that when a contribution is made, 10 BAT is being subtracted from the amount

Ensured that once you've selected 10 BAT as the default monthly budget, it's correctly being reflected under ledger-state.json

"fee": {
  "currency": "BAT",
  "amount": 10
},

@LaurenWags
Copy link
Member

Verified items from #12465 (comment) on MacOS.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 11 (Release Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @bsclifton @NejcZdovc @bradleyrichter @srirambv @LaurenWags