Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Adds lower amount into monthly budget #12473

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 3, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Resolves #12465

Auditors:

Test plan:

  1. Enable payments
  2. Make sure that you see 10 BAT option

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
@NejcZdovc NejcZdovc changed the title Fixes context menu mute item not being displayed Adds lower amount into monthly budget Jan 3, 2018
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! However, you missed a spot 😄

let randomContributionAmount = [25, 50, 75, 100][ Math.round(Math.random() * 3) ]

@NejcZdovc
Copy link
Contributor Author

@bsclifton nice one, fixed

@codecov-io
Copy link

codecov-io commented Jan 3, 2018

Codecov Report

Merging #12473 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12473   +/-   ##
=======================================
  Coverage   55.85%   55.85%           
=======================================
  Files         278      278           
  Lines       26996    26996           
  Branches     4364     4364           
=======================================
  Hits        15079    15079           
  Misses      11917    11917
Flag Coverage Δ
#unittest 55.85% <0%> (ø) ⬆️
Impacted Files Coverage Δ
app/renderer/components/common/switchControl.js 83.67% <0%> (ø) ⬆️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 8a781e2 into brave:master Jan 3, 2018
bsclifton added a commit that referenced this pull request Jan 3, 2018
 Adds lower amount into monthly budget
bsclifton added a commit that referenced this pull request Jan 3, 2018
 Adds lower amount into monthly budget
@bsclifton
Copy link
Member

master 8a781e2
0.21.x 86fb1d0
0.20.x b3377bc

@bradleyrichter
Copy link
Contributor

thanks guys!

@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 Jan 3, 2018
bsclifton added a commit that referenced this pull request Jan 3, 2018
 Adds lower amount into monthly budget
@bsclifton
Copy link
Member

0.19.x 43f717b

@bsclifton
Copy link
Member

Whoops! Just noticed we forgot to add the 200 option 😛

@NejcZdovc
Copy link
Contributor Author

@bsclifton oh really, I didn't even notice it because we were only talking about 10 BAT option 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants