This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Adds lower amount into monthly budget #12473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
hotfix/#12465-amount
branch
from
January 3, 2018 13:26
bde696f
to
767bab7
Compare
NejcZdovc
changed the title
Fixes context menu mute item not being displayed
Adds lower amount into monthly budget
Jan 3, 2018
bsclifton
suggested changes
Jan 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! However, you missed a spot 😄
let randomContributionAmount = [25, 50, 75, 100][ Math.round(Math.random() * 3) ] |
Resolves brave#12465 Auditors: Test Plan:
@bsclifton nice one, fixed |
NejcZdovc
force-pushed
the
hotfix/#12465-amount
branch
from
January 3, 2018 16:51
767bab7
to
93c4161
Compare
Codecov Report
@@ Coverage Diff @@
## master #12473 +/- ##
=======================================
Coverage 55.85% 55.85%
=======================================
Files 278 278
Lines 26996 26996
Branches 4364 4364
=======================================
Hits 15079 15079
Misses 11917 11917
|
bsclifton
approved these changes
Jan 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
bsclifton
added a commit
that referenced
this pull request
Jan 3, 2018
Adds lower amount into monthly budget
bsclifton
added a commit
that referenced
this pull request
Jan 3, 2018
Adds lower amount into monthly budget
thanks guys! |
bsclifton
added a commit
that referenced
this pull request
Jan 3, 2018
Adds lower amount into monthly budget
0.19.x 43f717b |
Whoops! Just noticed we forgot to add the 200 option 😛 |
@bsclifton oh really, I didn't even notice it because we were only talking about 10 BAT option 😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Resolves #12465
Auditors:
Test plan:
Reviewer Checklist:
Tests