Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

right click on bookmark folder tree to add bookmark doesn't always add bookmark #12477

Closed
LaurenWags opened this issue Jan 3, 2018 · 0 comments
Closed

right click on bookmark folder tree to add bookmark doesn't always add bookmark #12477

LaurenWags opened this issue Jan 3, 2018 · 0 comments
Assignees
@NejcZdovc
Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2018 •
edited by bsclifton
Loading

Test plan

  1. Clean profile
  2. Open Bookmark Manager.
  3. Add a bookmark folder under 'Bookmarks Toolbar'
  4. Right click on added folder and select 'Add Bookmark'
  5. Add a bookmark. Verify it displays.
  6. Right click on added folder and select 'Add Bookmark' again
  7. Add a bookmark. Verify it also displays

Description

In the Bookmark Manager, if you right click on a Folder to add a bookmark, the bookmark isn't always added.

Steps to Reproduce

  1. Clean profile on 0.20.14.
  2. Open Bookmark Manager.
  3. Add a bookmark folder under 'Bookmarks Toolbar'
  4. Right click on added folder and select 'Add Bookmark'
  5. Add a bookmark. Verify it displays.
  6. Right click on added folder and select 'Add Bookmark' again
  7. Add a bookmark.

Actual result:
Bookmark is not added:
rt-click-folder-add-bkmk-02014-2

Expected result:
Bookmark should be added as it is in 0.19.123:
rt-click-folder-add-bkmk-019123-2

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.14
V8 | 6.3.292.48
rev | 5d75826
Muon | 4.5.33

Reproducible on current live release:
no

Additional Information

Can add more than one bookmark via right click on folder tree for 'Bookmarks Toolbar' but then unable to add bookmarks to sub folders via right click on folder tree (this works in 0.19.123)
rt-click-folder-add-bkmk-02014
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@LaurenWags LaurenWags mentioned this issue Jan 3, 2018
Closed
@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 4, 2018
@NejcZdovc
Fixes adding bookmarks and folders to the existing folders
b383c5b 
Resolves brave#12478
Resolves brave#12477

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 4, 2018
Merged
10 tasks
This was referenced Jan 9, 2018
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
4 participants
@bsclifton @NejcZdovc @srirambv @LaurenWags