Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

right click on bookmark folder tree to add folder doesn't always add folder #12478

Closed
LaurenWags opened this issue Jan 3, 2018 · 0 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2018

Test plan

  1. Clean profile
  2. Open Bookmark Manager.
  3. Add a sub-folder under Bookmarks Toolbar.
  4. Add a bookmark to this sub-folder (any method)
  5. Right click on the sub-folder and select 'Add Folder'
  6. Fill out information and select Done. Folder should be added

Description

In the Bookmark Manager, if you right click on a Folder to add a sub folder, the folder isn't always added.

Steps to Reproduce

  1. Clean profile 0.20.14
  2. Open Bookmark Manager.
  3. Add a sub-folder under Bookmarks Toolbar.
  4. Add a bookmark to this sub-folder (any method)
  5. Right click on the sub-folder and select 'Add Folder'
  6. Fill out information and select Done. Folder is not added.
  7. Try to add folder another way (i.e. icon in folder tree list pane). Folder is added.

Actual result:
Folder is not added in step 6 when right click -> Add Folder:

rt-click-folder-add-folder-02014

Expected result:
Folder should be added as it was in 0.19.123:

rt-click-folder-add-folder-019123

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.14
V8 | 6.3.292.48
rev | 5d75826
Muon | 4.5.33

Reproducible on current live release:
No

Additional Information

Similar to #12477

@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 4, 2018
bsclifton added a commit that referenced this issue Jan 4, 2018
Fixes adding bookmarks and folders to the existing folders
bsclifton added a commit that referenced this issue Jan 4, 2018
Fixes adding bookmarks and folders to the existing folders
bsclifton added a commit that referenced this issue Jan 4, 2018
Fixes adding bookmarks and folders to the existing folders
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.