Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add setting to enable site isolation #12490

Closed
diracdeltas opened this issue Jan 3, 2018 · 6 comments · Fixed by #12491
Closed

add setting to enable site isolation #12490

diracdeltas opened this issue Jan 3, 2018 · 6 comments · Fixed by #12491

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jan 3, 2018

Test Plan: #12491

context: https://www.chromium.org/Home/chromium-security/ssca

We should have a setting to enable site isolation on all sites: https://www.chromium.org/Home/chromium-security/site-isolation. The memory footprint could be a concern, but the other known issues seem like relatively minor edge cases.

@diracdeltas diracdeltas added this to the 0.19.x Hotfix 11 milestone Jan 3, 2018
@diracdeltas diracdeltas self-assigned this Jan 4, 2018
diracdeltas added a commit that referenced this issue Jan 4, 2018
fix #12490

Test Plan:
1. go to preferences > Security
2. enable Strict Site Isolation at the bottom of the page
3. restart
4. open devtools and go to https://jsfiddle.net/avse30aj/. you should not see any requests to fiddle.jshell.net in the network requests panel.
@diracdeltas
Copy link
Member Author

decided to enable off-by-default at first due to high likelihood of breaking sites

@BrendanEich
Copy link
Member

+1 on this. The hope is that with our by-default aggressive 3rd party blocking, the memory problems that Chrome is contending with won't be nearly as challenging.

@diracdeltas diracdeltas changed the title enable site isolation add setting to enable site isolation Jan 4, 2018
@srirambv
Copy link
Collaborator

srirambv commented Jan 5, 2018

@diracdeltas should we add a info flag to the Site Isolation header linking the context?

@diracdeltas
Copy link
Member Author

Weirdly, the site isolation setting doesn't seem to work in the 0.19.126 packaged build, but it does work when running the 0.19.126dev tag using 'npm start'. @bridiver any ideas what could cause this?
test steps:

  1. load https://jsfiddle.net/avse30aj/
  2. open devtools
  3. make sure no requests to jshell.net appear in the devtools panel

@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2018

When viewing https://jsfiddle.net/avse30aj/ with site isolation enabled via about:preferences#security, you'll still see network requests from fiddle.jshell.net under the browser console, example:

  • https://fiddle.jshell.net/js/lib/dummy.js
  • https://fiddle.jshell.net/avse30aj/show/
  • https://fiddle.jshell.net/js/_dist-editor.js?update_05_01_2018_1

@diracdeltas mentioned that this is working when running from source using npm but doesn't seem to be working when using the packaged 0.19.126 build.

Reproducible on all three platforms:

  • macOS using 0.19.126 - reproduced by @LaurenWags and @diracdeltas
  • Win 10 x64 using 0.19.126 - reproduced
  • Ubuntu 17.10 x64 - reproduced

@kjozwiak kjozwiak reopened this Jan 5, 2018
diracdeltas added a commit that referenced this issue Jan 5, 2018
Fix #12490 for packaged builds

Test Plan:
1. build a package locally using npm run build-package
2. repeat test plan from #12491
3. it should work now
@bsclifton
Copy link
Member

bsclifton commented Jan 5, 2018

Fixed with #12518

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.