This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
add setting for enabling site isolation #12491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #12490 Test Plan: 1. go to preferences > Security 2. enable Strict Site Isolation at the bottom of the page 3. restart 4. open devtools and go to https://jsfiddle.net/avse30aj/. you should not see any requests to fiddle.jshell.net in the network requests panel.
this seems to work in the sense that it creates a new process for the iframe. however, for some reason, the iframe crashes on https://jsfiddle.net/avse30aj/ with site isolation enabled in Brave whereas it loads fine in Chrome with site isolation enabled |
Codecov Report
@@ Coverage Diff @@
## master #12491 +/- ##
==========================================
- Coverage 55.91% 55.9% -0.01%
==========================================
Files 278 278
Lines 26975 26978 +3
Branches 4363 4363
==========================================
+ Hits 15082 15083 +1
- Misses 11893 11895 +2
|
jumde
approved these changes
Jan 4, 2018
opened follow-up issue: brave/muon#422 |
diracdeltas
added a commit
that referenced
this pull request
Jan 4, 2018
add setting for enabling site isolation
diracdeltas
added a commit
that referenced
this pull request
Jan 4, 2018
add setting for enabling site isolation
diracdeltas
added a commit
that referenced
this pull request
Jan 4, 2018
add setting for enabling site isolation
This was referenced Jan 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12490
Test Plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests