Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave Stopped playing Facebook videos #14358

Closed
egferro opened this issue Jun 8, 2018 · 14 comments
Closed

Brave Stopped playing Facebook videos #14358

egferro opened this issue Jun 8, 2018 · 14 comments
Assignees
@diracdeltas @Slava
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat workaround/shields-down
Milestone
0.23.x (Release C...

Comments

@egferro
Copy link

egferro commented Jun 8, 2018 •
edited by bsclifton
Loading

Test plan

See #14465

Original issue description

Brave version 0.22.727
Windows 10
Today brave stopped playing facebook videos.
When you click play they turn into larger version (almost full screen) but the video never starts.
Please advise

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information
@eljuno
Copy link
Contributor

eljuno commented Jun 9, 2018

+1s from community https://community.brave.com/t/facebook-video-wont-play-with-the-shields-up-mac-os/23568?u=eljuno

Also +1 from me. cc @bsclifton

@Miyayes
Copy link

Miyayes commented Jun 11, 2018

+2 from Reddit community: https://www.reddit.com/r/BATProject/comments/8q4r1n/facebook_blocking_brave/

@LaurenWags
Copy link
Member

Reproduces on 0.22.808, adjusting my cookie setting to 'Allow All Cookies' for FB seemed to fix it.

@eljuno
Copy link
Contributor

eljuno commented Jun 11, 2018

+1s from Reddit https://www.reddit.com/r/brave_browser/comments/8pzoht/videos_not_playing_on_facebook/

@bsclifton bsclifton added this to the Triage Backlog milestone Jun 11, 2018
@bsclifton
Copy link
Member

If this requires 3rd party cookies, I'm not sure if we want to fix it. cc: @diracdeltas

@Jacalz
Copy link
Contributor

Jacalz commented Jun 12, 2018

+1 from DM on the community

@srirambv
Copy link
Collaborator

+1 from https://community.brave.com/t/videos-dont-play-on-facebook-with-brave/23788

@dgurns
Copy link

dgurns commented Jun 13, 2018

+1

using Macbook Pro, OS 10.13.3

@eszpee
Copy link

eszpee commented Jun 14, 2018

Same on OS X

@diracdeltas diracdeltas mentioned this issue Jun 19, 2018
Closed
@srirambv
Copy link
Collaborator

Updating workaround label. 3rd party cookies don't fix only shields down allows you to play video. More details on #14448

@Slava
Copy link
Contributor

Slava commented Jun 19, 2018

I tested it on Mac and for me switching from "block 3rd party cookies" to "allow all cookies" fixes the problem. Not sure yet what is going on here, for starters the Facebook player makes xhr requests to load pieces of the video and in a normal operation a request looks something like this:

screen shot 2018-06-19 at 3 10 35 pm

But when the 3rd party cookies are blocked, the response from the server is a 302 redirect which doesn't return anything else

screen shot 2018-06-19 at 3 11 28 pm

From where I stand now it is not obvious to me we can do anything besides having a work-around of allowing 3rd-party cookies to play Facebook videos.

@Slava
Copy link
Contributor

Slava commented Jun 19, 2018

Weird, testing the same page on Chrome with an extension tracking 3rd party cookies didn't reveal anything special

Slava added a commit to Slava/browser-laptop that referenced this issue Jun 19, 2018
@Slava
Add Facebook CDN to the referrer exceptions list
8ff13c0 
Fixes brave#14358

Had to tweak the logic to accept regexs to catch all FBCDN subdomains

Auditors:

Test Plan:
Go to any facebook video page and make sure the video plays at various points
You can use this page as an example: https://www.facebook.com/peopleareawesome/videos/1393626100686564/
@Slava Slava mentioned this issue Jun 19, 2018
Merged
10 tasks
@Slava
Copy link
Contributor

Slava commented Jun 19, 2018

Seems like a referer problem after all, see #14465

This was referenced Jun 25, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 25, 2018 •
edited by btlechowski
Loading

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Ubuntu 18.04 x64 using the following build:

  • 0.23.17 bc754eb
  • muon: 7.1.2
  • libchromiumcontent: 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.17 - bc754eb
  • Muon - 7.1.2
  • libchromiumcontent - 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 25, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@Slava Slava

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include webcompat workaround/shields-down
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests