Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Facebook CDN to the referrer exceptions list #14465

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

Slava
Copy link
Contributor

@Slava Slava commented Jun 19, 2018

Fixes #14358

Had to tweak the logic to accept regexs to catch all FBCDN subdomains

Auditors:

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Go to any facebook video page and make sure the video plays at various points
You can use this page as an example: https://www.facebook.com/peopleareawesome/videos/1393626100686564/

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes brave#14358

Had to tweak the logic to accept regexs to catch all FBCDN subdomains

Auditors:

Test Plan:
Go to any facebook video page and make sure the video plays at various points
You can use this page as an example: https://www.facebook.com/peopleareawesome/videos/1393626100686564/
@Slava
Copy link
Contributor Author

Slava commented Jun 19, 2018

@diracdeltas

Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bsclifton bsclifton merged commit 8fd8073 into brave:master Jun 20, 2018
bsclifton added a commit that referenced this pull request Jun 20, 2018
Add Facebook CDN to the referrer exceptions list
@bsclifton
Copy link
Member

master 8fd8073
0.24.x 1b3fa64

bsclifton added a commit that referenced this pull request Jun 22, 2018
Add Facebook CDN to the referrer exceptions list
@bsclifton
Copy link
Member

Uplifted to 0.23.x with a13dd4a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants