This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add browserButton_subtleItem to BrowserButton component #9072
Assignees
Labels
Milestone
Comments
This was referenced May 26, 2017
alexwykoff
modified the milestones:
0.16.200,
0.16.100 (Frozen, only critical adds from here)
|
I know it was moved after our triage meeting today but moving back to |
cezaraugusto
modified the milestones:
0.17.x (Frozen, only critical adds from here),
0.18.x
cezaraugusto
pushed a commit
that referenced
this issue
May 30, 2017
Closes #9072 Addresses #9071 Also: - Add lines in the same way as LESS files - Add comments for refenrence (We could remove them after refactoring work) - Fix regressions on browserButton_default - Add globalStyles.button.color to replace it with globalStyles.button.default.color - Fix a typo Auditors: Test Plan 1: (0. Take a screenshot of the buttons section on about:styles before testing the PR for later use) 1. Open about:styles 2. Click "buttons" 3. Take another screenshot of the section 4. Compare the two screenshots and make sure they look same Test Plan 2: 1. Open about:styles 2. Toggle developer tools 3. Make sure button's padding is set to '5px 16px' Test Plan 3: 1. Open downloadme.org 2. Click "Advanced" button 3. Make sure the button is not pushed down 4. Click "Hide advanced" button 5. Make sure the button does not move
This was referenced Jun 19, 2017
94 tasks
This was referenced Jun 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#9026 (comment)
Describe the issue you encountered: Add browserButton_subtleItem to BrowserButton component.
Extra QA steps:
1.
2.
3.
Any related issues: converting BrowserButton tracking issue #9071
The text was updated successfully, but these errors were encountered: