This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix margin around the button on about:safebrowsing & Add browserButton_subtleItem fixing regressions #9026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/about/safebrowsing.js
Outdated
| </div> | ||
| ? <section> | ||
| <div className='buttons'> | ||
| <Button className='subtleButton' |
There was a problem hiding this comment.
could we take advantage of this PR and add subtleButton to <BrowserButton> component?
There was a problem hiding this comment.
ah right, I've totally forgot about that component :-p
I'll replace it with that, adding subtleButton. Thanks for heads up.
luixxiul
added
PR/work-in-progress ⚒
misc/button
and removed
PR/needs-QA-attention ☕
bug
labels
luixxiul
changed the title
|
on the 2nd commit I fixed several regressions introduced with #8568 for 0.15.3, which seem to me a not blocker. I think it's fine to wait for 0.16 series. |
| paddingLeft: '16px', | ||
|
|
||
| // cf: https://github.com/brave/browser-laptop/blob/548e11b1c889332fadb379237555625ad2a3c845/less/button.less#L98 | ||
| minWidth: `calc(${globalStyles.spacing.defaultFontSize} * 6)`, // issue #6384 |
|
|
||
| browserButton_subtleItem: { | ||
| // cf: https://github.com/brave/browser-laptop/blob/548e11b1c889332fadb379237555625ad2a3c845/less/button.less#L151-L152 | ||
| background: '#ccc', |
There was a problem hiding this comment.
this should belong to global styles
There was a problem hiding this comment.
Fixed with 03a9abd
added 3 commits
May 29, 2017 22:46
Closes #9072 Addresses #9071 Also: - Add lines in the same way as LESS files - Add comments for refenrence (We could remove them after refactoring work) - Fix regressions on browserButton_default - Add globalStyles.button.color to replace it with globalStyles.button.default.color - Fix a typo Auditors: Test Plan 1: (0. Take a screenshot of the buttons section on about:styles before testing the PR for later use) 1. Open about:styles 2. Click "buttons" 3. Take another screenshot of the section 4. Compare the two screenshots and make sure they look same Test Plan 2: 1. Open about:styles 2. Toggle developer tools 3. Make sure button's padding is set to '5px 16px' Test Plan 3: 1. Open downloadme.org 2. Click "Advanced" button 3. Make sure the button is not pushed down 4. Click "Hide advanced" button 5. Make sure the button does not move
This was referenced May 30, 2017
|
@cezaraugusto thanks for review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the 1st commit:
Fix margin around the button on about:safebrowsing
On the 2nd commit:
Add browserButton_subtleItem fixing regressions
Closes #8945
Closes #9072
Addresses #9025
Addresses #9071
Auditors:
Test Plan 1:
Test Plan 2:
Test Plan 3:
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests