Address bar should be active for about:newtab

[Sh1d0w]

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).

This issue was fixed via #3718
but was returned with feedback from the QA.

Now it should properly handle switching to new tab via shortcut or mouse.

Fixes #3712
Auditors:
@bbondy

Test Plan:
While switching to a new tab eighter via shortcut or mouse click
the url bar should be focused.

[bbondy]

thanks would you mind adding some tests for this?

[bbondy]

does url bar active mean auto complete can be open? Just making sure we have to treat focused and active separately. And can we get an accurate view of focused with this state always?

[Sh1d0w]

@bbondy

1. URL_BAR_ACTIVE = true - it is visible and not hidden by the page title
2. URL_BAR_SELECTED = true - means the text you have typed in is selected (also url bar gains focus)
3. URL_BAR_FOCUSED = true - means the focus is on the url bar (the cursor will blink at the end of the text in the url bar, if any)

Now these are 3 different states, and they can lay different results if combined together. For example if you type something in the url bar, blur and trigger focus, the cursor will blink at the end of the text and if you start typing it will append to the text. But if you do the same and instead trigger url bar selected and then focus, the text you typed in will be selected and if you start typing you will overwrite it.

I tried to replicate the behaviour of FF and Chrome when you switch tabs. Currently if you type a text switch tabs and go back to the tab you typed in the focus is on the url bar and the cursor is a t the end of the text so you can continue typing.

Will add some more tests today or tomorrow. If this blocks the current release you can move it for the next one.

[bbondy]

Thanks, I'll merge but pls add some tests because the interactions can break in the future.