Address bar should be active for about:newtab

docs/windowActions.md

@@ -408,6 +408,16 @@ are no autocomplete results.
 
 
 
+### setUrlBarFocused(isFocused) 
+
+Marks the URL bar as focused or not.
+
+**Parameters**
+
+**isFocused**: `boolean`, Whether or not the URL bar should be marked as focused
+
+
+
 ### setActiveFrameShortcut(frameProps, activeShortcut, activeShortcutDetails) 
 
 Dispatches a message to the store to indicate that the pending frame shortcut info should be updated.

js/actions/windowActions.js

@@ -574,6 +574,17 @@ const windowActions = {
     })
   },
 
+  /**
+   * Marks the URL bar as focused or not.
+   *
+   * @param {boolean} isFocused - Whether or not the URL bar should be marked as focused
+   */
+  setUrlBarFocused: function (isFocused) {
+    dispatch({
+      actionType: WindowConstants.WINDOW_SET_URL_BAR_FOCUSED,
+      isFocused
+    })
+  },
   /**
    * Dispatches a message to the store to indicate that the pending frame shortcut info should be updated.
    *

js/components/frame.js

@@ -356,7 +356,7 @@ class Frame extends ImmutableComponent {
         // to the UrlBar
         if (this.props.location === 'about:newtab') {
           windowActions.setUrlBarActive(true)
-          windowActions.setUrlBarSelected(false)
+          windowActions.setUrlBarFocused(true)
         } else {
           // If it is a regular webpage, just focus the webcontents
           this.webview.focus()

js/components/tab.js

@@ -86,8 +86,15 @@ class Tab extends ImmutableComponent {
     dnd.onDragOver(dragTypes.TAB, this.tabNode.getBoundingClientRect(), this.props.tab.get('frameKey'), this.draggingOverData, e)
   }
 
-  setActiveFrame () {
+  setActiveFrame (event) {
+    event.stopPropagation()
     windowActions.setActiveFrame(this.frame)
+
+    if (this.frame.get('location') === 'about:newtab') {
+      windowActions.setUrlBarActive(true)
+      windowActions.setUrlBarFocused(true)
+      windowActions.setUrlBarSelected(false)
+    }
   }
 
   onCloseFrame (event) {

js/constants/windowConstants.js

@@ -39,6 +39,7 @@ const windowConstants = {
   WINDOW_CLEAR_CLOSED_FRAMES: _,
   WINDOW_SET_ACTIVE_FRAME_SHORTCUT: _,
   WINDOW_SET_URL_BAR_SELECTED: _,
+  WINDOW_SET_URL_BAR_FOCUSED: _,
   WINDOW_SET_SEARCH_DETAIL: _,
   WINDOW_SET_FIND_DETAIL: _,
   WINDOW_SET_BOOKMARK_DETAIL: _, // If set, also indicates that add/edit is shown

js/stores/windowStore.js

@@ -555,6 +555,9 @@ const doAction = (action) => {
     case WindowConstants.WINDOW_SET_URL_BAR_AUTCOMPLETE_ENABLED:
       windowState = windowState.setIn(activeFrameStatePath().concat(['navbar', 'urlbar', 'suggestions', 'autocompleteEnabled']), action.enabled)
       break
+    case WindowConstants.WINDOW_SET_URL_BAR_FOCUSED:
+      windowState = windowState.setIn(activeFrameStatePath().concat(['navbar', 'urlbar', 'focused']), action.isFocused)
+      break
     case WindowConstants.WINDOW_SET_URL_BAR_SELECTED:
       const urlBarPath = activeFrameStatePath().concat(['navbar', 'urlbar'])
       windowState = windowState.mergeIn(urlBarPath, {