Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Redo: Add copy to clipboard for about brave page #6186

Closed
wants to merge 2 commits into from
Closed

Redo: Add copy to clipboard for about brave page #6186

wants to merge 2 commits into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 13, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Closes #6183

Test Plan:

  1. Visit about:about

gyandeeps and others added 2 commits December 14, 2016 02:47
Closes #6183

Redo PR #6107 (which was reverted with #6184)

- cherry-picked 942e95c
- Added brave.less for about:brave to fix regression on about pages

TODO: Pick up properties from history.less into brave.less

Auditors: @alexwykoff

Test Plan:
1. Visit about:about
@luixxiul
Copy link
Contributor Author

Closing for now

@luixxiul luixxiul closed this Dec 19, 2016
@luixxiul luixxiul deleted the fix-regression-about-brave branch December 19, 2016 14:52
@bsclifton
Copy link
Member

bsclifton commented Dec 19, 2016

@luixxiul I think this was a good fix 😄 (didn't need to be closed yet- just needed a reviewer)

@gyandeeps as the original author, would you be interesting in reviewing these changes? You had originally submitted #6107 and that commit along with some tweaks were pulled into this PR by @luixxiul. I think his fixes are great 😄

If it looks good, (since this branch has been deleted) you should be able to create a new branch and cherry-pick both commits in (I can help with that, if you're not sure). Would be great to get this one closed out 😄

@gyandeeps
Copy link
Contributor

gyandeeps commented Dec 19, 2016

I can do that but i saw that the reverted commit has been committed basck in here: 5324f3c

Let me know what your thoughts are and will act accordingly. thanks

@bsclifton
Copy link
Member

@gyandeeps perfect- I missed that 😄 I just now confirmed that your change is there and working great! So we just need to fix the alignment on about:about. I'll get that taken care of

@gyandeeps
Copy link
Contributor

@bsclifton Here is the fix for about:about title: #6299

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants