Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix copy version info tooltip #6392

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Fix copy version info tooltip #6392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/about/brave.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class AboutBrave extends React.Component {
<div className='siteDetailsPageContent aboutAbout'>
<div className='title'>
<span className='sectionTitle' data-l10n-id='versionInformation' />
<span className='fa fa-clipboard' title='Copy password to clipboard' onClick={this.onCopy} />
<span className='fa fa-clipboard' title='Copy to clipboard' onClick={this.onCopy} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this should work, but maybe another fix is needed for passing attributes to about pages, I'll merge this in the meantime either way though.
copyToClipboard.title=Copy to clipboard

Copy link
Member

@bsclifton bsclifton Dec 22, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things ( cc: @liunkae ):

  1. We're missing data-l10n-id for this item. We need it to look like this:
    <span data-l10n-id='copyToClipboard' className='fa fa-clipboard' onClick={this.onCopy} />
  2. When you look at about-brave.html, you'll see that for localization this file uses app.properties. Inside the en-US version of this file, you'll need to be having something like this: copyToClipboard.title=Copy to clipboard

</div>
<SortableTable
headings={['Name', 'Version']}
Expand Down