This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Unhide bitwarden Password Manager resolves #7921 #8776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
please also add bitwarden data to extensionsUtil.js file so it can be seen under prefs extensions list. You can follow the pattern as other extensions so something like the below should work:
{
id: bitwarden,
name: 'bitwarden',
description: 'bitwardenDesc',
icon: 'img/extensions/bitwarden-128.png'
},
You can double-test that by going to about:preferences#extensions and being able to enable/disable bitwarden.
This reverts commit db26cac. Auditors: @bsclifton See also brave/muon@14c0cd7 Fix brave#7344
Fix brave#8777 Auditors: @bsclifton
Fixes brave#8778 Auditors: @bridiver
Auditors: @bbondy, @bsclifton
fix brave#8779 Test Plan: 1. disable scripts on twitter.com 2. open twitter.com in a private tab. scripts should be disabled. 3. click the noscript icon to allow scripts in the private tab. 4. load twitter again in a regular tab. scripts should still be disabled.
…st the changes and respond to them when the browser process updates
It conflicts with devtools shortcut on Windows Modification to brave#3121 Auditors: @srirambv
Auditors: @bbondy
auditors @bbondy @bsclifton
Auditors: Test Plan: n/a
auditors @bbondy @bsclifton
Fixes issue introduced with brave@f4283c0#diff-2be38b3d97f35cd818780bac4be979c4L589 Auditors: @bridiver
auditors @bbondy @bsclifton
…perty 'get' of null" errors during tear off tab after brave#8782 Auditors: @bridiver
auditors @bbondy
auditors @NejcZdovc
…mparisons to return false instead of true
|
Well, I screwed that that one up... |
|
Not sure how to recover from that screwup. Just created a fresh new PR instead... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).resolves #7921
Test Plan: