This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Merge C68 into master #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
force-pushed
the
C68-master
branch
4 times, most recently
from
b7f7800
to
7d335a0
Compare
FAILED: obj/mojo/public/cpp/platform/platform/named_platform_channel_win.obj
../../mojo/public/cpp/platform/named_platform_channel_win.cc(58,8): error: no member named 'unique_ptr' in namespace 'std'
std::unique_ptr<void, decltype(::LocalFree)*> p(security_desc, ::LocalFree);
~~~~~^
../../mojo/public/cpp/platform/named_platform_channel_win.cc(58,23): error: expected '(' for function-style cast or type construction
std::unique_ptr<void, decltype(::LocalFree)*> p(security_desc, ::LocalFree);
~~~~^
2 errors generated.
…t get destroyed prematurely
`ServiceWorkerProcessManager::AllocateWorkerProcess` can have correct site instance set by `use_url_from_storage_partition` fix brave/browser-laptop#14806 Auditor: @bridiver
…as a result of losing a race condition) Fixes brave/browser-laptop#14409 Auditors: @bridiver
…fetime without any other changes for now fixes brave/browser-laptop#14893 auditors @darkdh
bridiver
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based C68 branch