Doesn't work under Node.js 6.0.0 #1000

vitaly-t · 2016-04-27T02:55:45Z

If we take the example on the main page:

var pg = require('pg');
var conString = "postgres://username:password@localhost/database";

//this initializes a connection pool
//it will keep idle connections open for a (configurable) 30 seconds
//and set a limit of 10 (also configurable)
pg.connect(conString, function(err, client, done) {
  if(err) {
    return console.error('error fetching client from pool', err);
  }
  client.query('SELECT $1::int AS number', ['1'], function(err, result) {
    //call `done()` to release the client back to the pool
    done();

    if(err) {
      return console.error('error running query', err);
    }
    console.log(result.rows[0].number);
    //output: 1
  });
});

And simply switch to Node.js 6.0.0, we are immediately getting an error:

error fetching client from pool { error: password authentication failed for user "postgres"
    at Connection.parseE (D:\NodeJS\tests\node_modules\pg\lib\connection.js:539:11)
    at Connection.parseMessage (D:\NodeJS\tests\node_modules\pg\lib\connection.js:366:17)
    at Socket.<anonymous> (D:\NodeJS\tests\node_modules\pg\lib\connection.js:105:22)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:172:18)
    at Socket.Readable.push (_stream_readable.js:130:10)
    at TCP.onread (net.js:535:20)
  name: 'error',
  length: 115,
  severity: 'FATAL',
  code: '28P01',
  detail: undefined,
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'src\\backend\\libpq\\auth.c',
  line: '304',
  routine: 'auth_failed' }

i.e. authentication doesn't work under the newly released Node.js 6.0.0

My Test environment:

Windows 10, 64-bit
Node.js 6.0.0 (released)

The text was updated successfully, but these errors were encountered:

migolo · 2016-04-27T03:00:37Z

I get the same error

error fetching client from pool { error: password authentication failed for user "username"
    at Connection.parseE (/usr/src/app/node_modules/pg/lib/connection.js:539:11)
    at Connection.parseMessage (/usr/src/app/node_modules/pg/lib/connection.js:366:17)
    at Socket.<anonymous> (/usr/src/app/node_modules/pg/lib/connection.js:105:22)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:172:18)
    at Socket.Readable.push (_stream_readable.js:130:10)
    at TCP.onread (net.js:535:20)
  name: 'error',
  length: 93,
  severity: 'FATAL',
  code: '28P01',
  detail: undefined,
  hint: undefined,
  position: undefined,
  internalPosition: undefined,
  internalQuery: undefined,
  where: undefined,
  schema: undefined,
  table: undefined,
  column: undefined,
  dataType: undefined,
  constraint: undefined,
  file: 'auth.c',
  line: '285',
  routine: 'auth_failed' }

My Test environment:

Docker Node v6.0.0

jadbox · 2016-04-27T03:04:50Z

Yep, same here as @migolo and @vitaly-t

(also, I think I need to wear sunglasses to fit into this community)

jadbox · 2016-04-27T03:05:50Z

I wonder how this happened? There shouldn't be an API breaking change in v6 other than the worker process API.

Btw, what's this file: 'auth.c' file being mentioned?

vitaly-t · 2016-04-27T03:10:41Z

Btw, what's this file: 'auth.c' file being mentioned?

That's where all the authentication mambo-jumbo happens inside PostgreSQL server code. It is always mentioned on any authentication-related error.

vitaly-t · 2016-04-27T03:17:37Z

I've done some initial debugging, and I am almost certain the issue is caused by one of the changes to the Buffer.

From the change-log:

The following significant changes have been made since the previous Node.js v5.0.0 release:

Buffer
- New Buffer constructors have been added
  #4682 and
  #5833.
- Existing Buffer() and SlowBuffer() constructors have been deprecated
  in docs #4682 and
  #5833.
- Previously deprecated Buffer APIs are removed
  #5048,
  #4594.
- Improved error handling #4514.
- The Buffer.prototype.lastIndexOf() method has been added
  #4846.

For example, if I do something like this:

Connection.prototype.parseCString = function(buffer) {
  console.log('BUFFER:', buffer.length);
  var start = this.offset;
  while(buffer[this.offset++] !== 0) { }
  return buffer.toString(this.encoding, start, this.offset - 1);
};

in file connection.js, i see immediate change in the received buffer length as I change to Node.js 6.0.0

slvnperron · 2016-04-27T05:52:33Z

Same issue here

ignitenet-martynas · 2016-04-27T12:04:00Z

Hello everyone,

Here's what fixes the Node v6.0.0 problem:

https://github.com/ignitenet-martynas/node-postgres/commit/77560fe1bbc80ba0a629720161d81dbb6286166d

Canop · 2016-04-27T12:11:18Z

I confirm it works for me

anyong · 2016-04-27T16:26:24Z

Works for me too.

vitaly-t · 2016-04-27T16:57:52Z

I confirm this to be the fix indeed! Thank you @ignitenet-martynas !

So it was the Buffer as I thought :)

@brianc Now we just need the PR to make into a new release ;) And I think it should be 4.6.0 ;)

vitaly-t · 2016-04-27T19:17:10Z

The issue has been resolved with 4.5.5 release.

Thank you @ignitenet-martynas and @brianc 👍

brianc · 2016-04-27T19:17:42Z

Thanks for your help with reporting it & digging in and finding it was an issue with the buffer @vitaly-t!!

Fixes the Node 6.0.0 issue: brianc/node-postgres#1000

see brianc/node-postgres#1000

ChALkeR · 2016-05-01T06:49:30Z

Btw, judging by the fix, this is probably due to by nodejs/node#5522, not the Buffer changes. crypto now treats strings as utf8, not as binary if no encoding is specified.

ignitenet-martynas · 2016-05-01T07:18:34Z

Precisely, @ChALkeR.

- There is a change in `Buffer` in node 6 that causes an issue with authentication in the `pg`/`pg.js` modules. - See brianc/node-postgres#1018 - Which references: brianc/node-postgres#1000 - This commit changes the pg library dependency to the version that contains the fix for this issue.

nicbarker · 2016-06-05T10:38:39Z

Sorry for zombying this issue but I seem to be having the same problem despite upgrading to pg 4.5.5 on node 6.2.1. Same error: password authentication failed for user. I'm using RDS if that helps - is there anyone else still experiencing this issue?

nicbarker · 2016-06-06T02:20:05Z

Apologies - this was my fault. Another issue masquerading as this one that I've managed to fix.

Makes it possible to use this in Node.js 6

ijunaid8989 · 2016-10-17T05:19:40Z

I am getting the same error right now am on node 6.0.0 and my lib/client also has var outer = Client.md5(Buffer.concat([new Buffer(inner), msg.salt]));

Make it possible to use the lib on node versions >= 6.0.0 brianc/node-postgres#1000

taufikmas · 2017-06-08T03:51:44Z

DOESnt work for me.
have same problem,,and i try your solution but still error, cannot 'gulp serve'
hope your help.

PS C:\webproj\dreamhouse-web-app> gulp serve
[10:45:36] Using gulpfile C:\webproj\dreamhouse-web-app\gulpfile.js
[10:45:36] Starting 'clean'...
[10:45:36] Finished 'clean' after 69 ms
[10:45:36] Starting 'watch'...
[10:45:36] Starting 'sass'...
[10:45:36] Starting 'html'...
[10:45:36] Starting 'fonts'...
[10:45:36] Starting 'scripts'...
[10:45:36] Finished 'scripts' after 118 ms
[10:45:36] Finished 'html' after 160 ms
[10:45:36] Finished 'fonts' after 177 ms
[10:45:38] Finished 'sass' after 2.14 s
7.6 MB bytes written (9.89 seconds)
[10:45:49] Finished 'watch' after 13 s
[10:45:49] Starting 'serve'...
Listening at: http://localhost:8200
[10:45:49] Finished 'serve' after 302 ms
events.js:160
throw er; // Unhandled 'error' event
^

error: password authentication failed for user "taufikmas"
at Connection.parseE (C:\webproj\dreamhouse-web-app\node_modules\pg\lib\connection.js:539:11)
at Connection.parseMessage (C:\webproj\dreamhouse-web-app\node_modules\pg\lib\connection.js:366:17)
at Socket. (C:\webproj\dreamhouse-web-app\node_modules\pg\lib\connection.js:105:22)
at emitOne (events.js:96:13)
at Socket.emit (events.js:188:7)
at readableAddChunk (_stream_readable.js:176:18)
at Socket.Readable.push (_stream_readable.js:134:10)
at TCP.onread (net.js:547:20)

vitaly-t · 2017-06-08T03:54:26Z

@fixduino did you test it under Node 4.x? Which version of node-postgres are you using?

taufikmas · 2017-06-08T03:56:42Z

i use latest node 6.0 . win10.
is node jss 6.0 not support pg 4.5.5?
i try for this tutorial https://github.com/dreamhouseapp/dreamhouse-web-app

vitaly-t · 2017-06-08T03:58:44Z

@fixduino try Node.js 4.x, your problem could be unrelated, i.e. if you still get the same error, then it is not related, and you simply got your password wrong.

brianc · 2017-06-08T03:59:51Z

@fixduino I'd need to see your code but it looks like you're using the wrong password.

taufikmas · 2017-06-08T04:04:49Z

i never put my password. where is location for set password? thx

taufikmas · 2017-06-08T04:29:30Z

client.js -- https://pastebin.com/XQYs5xWv

conection-parameters.js -- https://pastebin.com/44mHmsgh
thx for help

taufikmas · 2017-06-09T02:00:17Z

SOLVED.. just a little mistake to set parameter..
in server.js
var connectionString = process.env.DATABASE_URL || 'postgres://postgres:admin@localhost:5432/dreamhouse'; //postgres://YourUserName:YourPassword@localhost:5432/YourDatabase";
thanks all.

win10. nodejs 6.0

endermaxximum · 2018-08-06T06:21:23Z

Excuse me I cannot open this link https://github.com/ignitenet-martynas/node-postgres/commit/77560fe1bbc80ba0a629720161d81dbb6286166d it show 404 not found

@ignitenet-martynas

ignitenet-martynas · 2018-08-06T06:26:41Z

@endermaxximum Well the fix has been integrated into node-postgres quite a while ago therefore I deleted the fork...

endermaxximum · 2018-08-06T07:01:53Z

okay.thank you

endermaxximum · 2018-08-08T02:42:05Z

This is the error that I got.

could you help me what wrong with my code? @ignitenet-martynas

here is my code: `var express = require('express'),
path = require('path'),
bodyParser = require('body-parser'),
cons = require('consolidate'),
dust = require('dustjs-helpers'),
pg = require('pg'),
app = express();
var pool = new pg.Pool()
// DB Connect String
// from owner Loaserver pass 00000000
var connect ="postgres://Loraserver:00000000@localhost/Lopicaserver";

// Assign Dust Engine to .dust Files
app.engine('dust', cons.dust);

// Set Default Ext .dust
app.set('view engine', 'dust');
app.set('views', __dirname + '/views');

// Set Public Folder
app.use(express.static(path.join(__dirname, 'public')));

// Body Parser Middleware
app.use(bodyParser.json());
app.use(bodyParser.urlencoded({ extended: false }));

app.get('/', function(req, res){

//connect using created pool
pool.connect(function(err, client, done) {
if(err) {
return console.error('error fetching client from pool', err);
}
client.query('SELECT * FROM public.loradata', function(err, result){
if(err){
return console.error('error running query', err);
}
res.render('index', {loradata: result.rows});
done();
});
});
});

// Server
app.listen(3000, function(){
console.log('Server Started On Port 3000');
});`

charmander · 2018-08-08T02:51:29Z

@endermaxximum Your connection string isn’t used anywhere. Pass it to the pool constructor (documentation):

var pool = new pg.Pool({
    connectionString: "postgres://Loraserver:00000000@localhost/Lopicaserver",
});

endermaxximum · 2018-08-08T06:00:24Z

Thank you so much.
@charmander

vitaly-t mentioned this issue Apr 27, 2016

Doesn't work under Node.js 6.0.0 vitaly-t/pg-promise#126

Closed

This was referenced Apr 27, 2016

Postgres authentication failing on node version 6.0 knex/knex#1371

Closed

Clean up node code Unleash/unleash#121

Closed

vitaly-t closed this as completed Apr 27, 2016

vitaly-t mentioned this issue Apr 27, 2016

unable to connect to RDS (aws) in node.js 6.0 #1003

Closed

subblue added a commit to subblue/massive-js that referenced this issue Apr 27, 2016

Updated node-postgres to v4.5.5

6878a38

Fixes the Node 6.0.0 issue: brianc/node-postgres#1000

subblue mentioned this issue Apr 27, 2016

Updated node-postgres dependency to v4.5.5 for a Node 6 issue dmfay/massive-js#245

Merged

Canop added a commit to Canop/miaou that referenced this issue Apr 28, 2016

fix postgres driver incompatibility with node 6

209d5f3

see brianc/node-postgres#1000

emirotin mentioned this issue Apr 29, 2016

Update node to 6.0.0 and npm to 3.8.8 balena-io-modules/open-balena-base#12

Merged

ivarconr mentioned this issue May 1, 2016

Cleanup api Unleash/unleash#127

Merged

11 tasks

This was referenced May 12, 2016

Node 6 compatibility db-migrate/sqlite#2

Closed

Node 6 compatibility db-migrate/pg#9

Closed

This was referenced May 15, 2016

Connection intermittently made, rejects connection with password authentication failure notice #1018

Closed

pg connection issue after node upgarde (possibly openssl related) #1019

Closed

andywhite37 mentioned this issue May 16, 2016

Fix for pg authentication issue in node 6+ rickbergfalk/postgrator#19

Merged

This was referenced May 19, 2016

Fix usage for Node 6 and Sails 0.12 BlueHotDog/sails-migrations#76

Merged

Update pg to 4.5.5 balderdashy/sails-postgresql#247

Merged

vitaly-t mentioned this issue May 24, 2016

Node V6 Incompatibility? #1029

Closed

joelmukuthu referenced this issue in One-com/node-mocha-docker-postgres Jun 30, 2016

Update pg to 6.0.1

6a6c6ca

Makes it possible to use this in Node.js 6

Flakebi mentioned this issue Feb 3, 2017

Etherpad authentication failed with postgres ether/etherpad-lite#3128

Closed

sarus mentioned this issue Feb 24, 2017

Intermittent Password Authentication Failure only on Node v6 #1229

Closed

aarontropy mentioned this issue Mar 18, 2017

Authentication failed with hostname vitaly-t/pg-promise#300

Closed

AndyMathys added a commit to AndyMathys/node-pg-jobs that referenced this issue May 10, 2017

Update package.json

d9a3bdc

Make it possible to use the lib on node versions >= 6.0.0 brianc/node-postgres#1000

This was referenced May 10, 2017

Update package.json AndyMathys/node-pg-jobs#1

Merged

Update PG library noblesamurai/node-pg-jobs#30

Closed

charmander added the bug label Dec 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doesn't work under Node.js 6.0.0 #1000

Doesn't work under Node.js 6.0.0 #1000

vitaly-t commented Apr 27, 2016 •

edited

Loading

migolo commented Apr 27, 2016

jadbox commented Apr 27, 2016 •

edited

Loading

jadbox commented Apr 27, 2016 •

edited

Loading

vitaly-t commented Apr 27, 2016

vitaly-t commented Apr 27, 2016 •

edited

Loading

slvnperron commented Apr 27, 2016

ignitenet-martynas commented Apr 27, 2016

Canop commented Apr 27, 2016

anyong commented Apr 27, 2016

vitaly-t commented Apr 27, 2016 •

edited

Loading

vitaly-t commented Apr 27, 2016

brianc commented Apr 27, 2016

ChALkeR commented May 1, 2016

ignitenet-martynas commented May 1, 2016 •

edited

Loading

nicbarker commented Jun 5, 2016

nicbarker commented Jun 6, 2016

ijunaid8989 commented Oct 17, 2016

taufikmas commented Jun 8, 2017

vitaly-t commented Jun 8, 2017

taufikmas commented Jun 8, 2017

vitaly-t commented Jun 8, 2017 •

edited

Loading

brianc commented Jun 8, 2017

taufikmas commented Jun 8, 2017

taufikmas commented Jun 8, 2017

taufikmas commented Jun 9, 2017

endermaxximum commented Aug 6, 2018

ignitenet-martynas commented Aug 6, 2018

endermaxximum commented Aug 6, 2018

endermaxximum commented Aug 8, 2018

charmander commented Aug 8, 2018 •

edited

Loading

endermaxximum commented Aug 8, 2018

Doesn't work under Node.js 6.0.0 #1000

Doesn't work under Node.js 6.0.0 #1000

Comments

vitaly-t commented Apr 27, 2016 • edited Loading

migolo commented Apr 27, 2016

jadbox commented Apr 27, 2016 • edited Loading

jadbox commented Apr 27, 2016 • edited Loading

vitaly-t commented Apr 27, 2016

vitaly-t commented Apr 27, 2016 • edited Loading

slvnperron commented Apr 27, 2016

ignitenet-martynas commented Apr 27, 2016

Canop commented Apr 27, 2016

anyong commented Apr 27, 2016

vitaly-t commented Apr 27, 2016 • edited Loading

vitaly-t commented Apr 27, 2016

brianc commented Apr 27, 2016

ChALkeR commented May 1, 2016

ignitenet-martynas commented May 1, 2016 • edited Loading

nicbarker commented Jun 5, 2016

nicbarker commented Jun 6, 2016

ijunaid8989 commented Oct 17, 2016

taufikmas commented Jun 8, 2017

vitaly-t commented Jun 8, 2017

taufikmas commented Jun 8, 2017

vitaly-t commented Jun 8, 2017 • edited Loading

brianc commented Jun 8, 2017

taufikmas commented Jun 8, 2017

taufikmas commented Jun 8, 2017

taufikmas commented Jun 9, 2017

endermaxximum commented Aug 6, 2018

ignitenet-martynas commented Aug 6, 2018

endermaxximum commented Aug 6, 2018

endermaxximum commented Aug 8, 2018

charmander commented Aug 8, 2018 • edited Loading

endermaxximum commented Aug 8, 2018

vitaly-t commented Apr 27, 2016 •

edited

Loading

jadbox commented Apr 27, 2016 •

edited

Loading

jadbox commented Apr 27, 2016 •

edited

Loading

vitaly-t commented Apr 27, 2016 •

edited

Loading

vitaly-t commented Apr 27, 2016 •

edited

Loading

ignitenet-martynas commented May 1, 2016 •

edited

Loading

vitaly-t commented Jun 8, 2017 •

edited

Loading

charmander commented Aug 8, 2018 •

edited

Loading