Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PG library #30

Closed
wants to merge 3 commits into from

Conversation

AndyMathys
Copy link

@AndyMathys AndyMathys commented May 10, 2017

Hello,

I'm currently running this lib in production and am running into some issues after an update of our node version.

The current used version of pg will not work on node 6 or node 7 due to this issue brianc/node-postgres#1000

This update makes the node-pg-jobs lib usable under newer node versions.

AndyMathys and others added 3 commits May 10, 2017 12:30
Make it possible to use the lib on node versions >= 6.0.0

brianc/node-postgres#1000
@AndyMathys AndyMathys changed the title New node version Update PG library May 10, 2017
@timlesallen
Copy link
Contributor

Thanks heaps @AndyMathys. I wanted to update travis as well so I've done a separate PR which should have the changes you want. It's merged and published. Thanks for your contributions. Interestingly the tests all pass before/after the upgrade to pg@6... What was broken exactly?

@AndyMathys
Copy link
Author

Thanks for the update, just redeployed with the latest version and it's working great again.

Before the update the library was unable to connect to the PG server when using a connection string and would fail with error message "password authentication failed for user xxx" as described in this PG issue brianc/node-postgres#1000

I'm not sure if this was only the case for complex connection strings or for all of them.

@timlesallen
Copy link
Contributor

@AndyMathys Ah, I see. Btw, I've given you commit access to the repo... See https://github.com/noblesamurai/node-pg-jobs/blob/master/CONTRIBUTING.md for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants