Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering problem with 40k+ rows #524

Closed
vysinsky opened this issue Jan 4, 2017 · 5 comments
Closed

Rendering problem with 40k+ rows #524

vysinsky opened this issue Jan 4, 2017 · 5 comments
Labels

Comments

@vysinsky
Copy link

vysinsky commented Jan 4, 2017

React-virtualized version: 8.8.1

Rows are disappearing when you scroll with 40 000 and more rows. It happens also in your demo: https://bvaughn.github.io/react-virtualized/#/components/Grid. It affects

I will try to revert to previous versions to identify where it happened.

Edit: version 8.7.1 seems to be ok.

@bvaughn bvaughn added the bug label Jan 4, 2017
@bvaughn
Copy link
Owner

bvaughn commented Jan 4, 2017

Interesting. Thank you for reporting this!

I am able to scrollbar-scroll through a couple hundred thousand rows, but wheel-scrolling does indeed break as you mention.

So this worked in 8.7.1 but broken in 8.8.0 huh... that would mean it's probably related to the cached inline style objects.

@bvaughn
Copy link
Owner

bvaughn commented Jan 4, 2017

If you have any time to dig into it before I do- I would appreciate the hand.

@bvaughn
Copy link
Owner

bvaughn commented Jan 8, 2017

FYI @vysinsky: This issue has been fixed with the recent 8.9.0 release.

Just verified that the demo page works with 500,000 rows.

cc @cheton RE /issues/524

@bvaughn bvaughn closed this as completed Jan 8, 2017
@vysinsky
Copy link
Author

vysinsky commented Jan 9, 2017

Awesome. Thank you @bvaughn!

@cheton
Copy link

cheton commented Jan 12, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants