Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering problems for Grid with big amount of rows #576

Closed
martinpesout opened this issue Feb 13, 2017 · 9 comments
Closed

Rendering problems for Grid with big amount of rows #576

martinpesout opened this issue Feb 13, 2017 · 9 comments

Comments

@martinpesout
Copy link

Hi, in the past there was a problem with rendering in Grid with 40k+ rows (#524). I've found that there is still some problem with this Grid.

Steps to reproduce:

  • Problem is visible on Grid with more rows. It works for table with 10000 rows. It doesn't work for table with 40000 rows.
  • Problem is visible in Chrome (reproduce on Mac devices and on Linux, even when using magic mouse and also on normal mouse with scrollwheel). Than we will have to do many times quick scrolling down and up.

You can reproduce it on your example https://bvaughn.github.io/react-virtualized/#/components/Grid with 40000 rows.

You will get this problem:

snimek obrazovky 2017-02-13 v 13 32 31

uno-13-2017 13-35-03

@lazyeasydev
Copy link

lazyeasydev commented Feb 13, 2017

I'm having the same issue exactly. Using a table and the infinite loader. I have a million row count, but 10,000 works fine.

screen shot 2017-02-13 at 10 41 34 am

Only happens on trackpad. Seems to work fine if I use the scroll bar.

@bvaughn
Copy link
Owner

bvaughn commented Feb 14, 2017

Hm. I'm unable to reproduce this myself (using Chrome 56.0.2924.87, macOS 10.12.3) on the demo site. I just cranked up the demo to 400,000 rows at 30px height each (12M pixels total). Trackpad "fling" scrolling, scrollbar "drag" scrolling, and arrow-key scrolling all seem fine.

high-compression-scrolling

Sorry for crappy demo video. Github has a 10MB limit.

@johnhaley81
Copy link

@martinpesout does it flicker if you use the scroll bar to scroll?

@bvaughn
Copy link
Owner

bvaughn commented Feb 14, 2017

To be clear- the above video I attached shows trackpad flinging, scrollbar dragging, and arrow key scrolling as well. All 3 seem fine to me.

@lazyeasydev
Copy link

It only happens at the very top.

@bvaughn
Copy link
Owner

bvaughn commented Feb 14, 2017

It only happens at the very top.

Ah! That's helpful. I see it now.

@bvaughn
Copy link
Owner

bvaughn commented Feb 14, 2017

I believe I have a fix 😄

bvaughn pushed a commit that referenced this issue Feb 14, 2017
@bvaughn
Copy link
Owner

bvaughn commented Feb 14, 2017

Fixed by commit e78036a. Will go out with version 9 (see PR #577)

@martinpesout
Copy link
Author

Sorry for later response. I'm in different timezone 😄 but confirmed. I also had this problem at the top of huge Grids. If I'll move to the middle I cannot reproduce it.

I see that fix is here. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants