Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for missing settings from wit-bindgen #273

Merged
merged 1 commit into from
Apr 17, 2024
Merged

add support for missing settings from wit-bindgen #273

merged 1 commit into from
Apr 17, 2024

Conversation

sehnryr
Copy link
Contributor

@sehnryr sehnryr commented Apr 17, 2024 •
edited
Loading

This adds support for the missing settings from wit-bindgen.
It is now a 1 to 1 copy of Opts fields (but with) from wit-bindgen-rust although not similarly sorted. (https://github.com/bytecodealliance/wit-bindgen/blob/90a1e547e1a4515a5769f5d157ffc519c5d851a3/crates/rust/src/lib.rs#L87-L189)
The with fields is represented here as a HashMap<String, String> instead of the Vec<(String, String)> from Opts since its TOML serialized representation is much more appropriate.

E.g. Cargo.toml

[package.metadata.component.bindings]
with = {foo: bar}
generate_unused_types = true

Closes: #257

@sehnryr sehnryr marked this pull request as ready for review April 17, 2024 18:04
peterhuene
peterhuene approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@peterhuene peterhuene merged commit e1715b0 into bytecodealliance:main Apr 17, 2024
6 checks passed
@zimond zimond mentioned this pull request May 16, 2024
Closed
mergify bot pushed a commit to andrzejressel/pulumi-wasm that referenced this pull request Jun 30, 2024
@renovate
chore(deps): update dependency cargo-component to 0.13.0 (#197)
59620f7 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cargo-component](https://github.com/bytecodealliance/cargo-component) | minor | `0.10.1` -> `0.13.0` |

---

### Release Notes

<details>
<summary>bytecodealliance/cargo-component (cargo-component)</summary>

### [`v0.13.2`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.13.2)

[Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.13.1...v0.13.2)

#### What's Changed

-   Add `cargo component serve` subcommand by [@&#8203;primoly](https://github.com/primoly) in [bytecodealliance/cargo-component#305
-   added wasmtime wasi args for `cargo component serve` by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#308

#### New Contributors

-   [@&#8203;primoly](https://github.com/primoly) made their first contribution in [bytecodealliance/cargo-component#305

**Full Changelog**: bytecodealliance/cargo-component@v0.13.1...v0.13.2

### [`v0.13.1`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.13.1)

[Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.13.0...v0.13.1)

#### What's Changed

-   More `cargo component new` generator fixes by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#304

**Full Changelog**: bytecodealliance/cargo-component@v0.13.0...v0.13.1

### [`v0.13.0`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.13.0)

[Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.12.0...v0.13.0)

#### What's Changed

-   set dev version by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#297
-   Bug fixes for targeting a world with resource borrows by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#300

**Full Changelog**: bytecodealliance/cargo-component@v0.12.0...v0.13.0

### [`v0.12.0`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.12.0)

[Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.11.0...v0.12.0)

#### What's Changed

-   add support for missing settings from wit-bindgen by [@&#8203;sehnryr](https://github.com/sehnryr) in [bytecodealliance/cargo-component#273
-   fix kebab case issue by [@&#8203;fibonacci1729](https://github.com/fibonacci1729) in [bytecodealliance/cargo-component#274
-   Help mesasage improvement ([#&#8203;138](https://github.com/bytecodealliance/cargo-component/issues/138)) by [@&#8203;chikoski](https://github.com/chikoski) in [bytecodealliance/cargo-component#278
-   Update the example to use the latest version of cargo-component by [@&#8203;rylev](https://github.com/rylev) in [bytecodealliance/cargo-component#283
-   fix test assertions after rust upgrade by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#287
-   Add `profile.release` to `Cargo.toml` generated by `cargo component new` by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#289
-   Update install instruction to use --locked by [@&#8203;fibonacci1729](https://github.com/fibonacci1729) in [bytecodealliance/cargo-component#292
-   Update to latest Warg release to support registry federation by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#288
-   removed unused warg-credentials dependency by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#295
-   Warg update 0.7 by [@&#8203;calvinrp](https://github.com/calvinrp) in [bytecodealliance/cargo-component#296

#### New Contributors

-   [@&#8203;sehnryr](https://github.com/sehnryr) made their first contribution in [bytecodealliance/cargo-component#273
-   [@&#8203;fibonacci1729](https://github.com/fibonacci1729) made their first contribution in [bytecodealliance/cargo-component#274
-   [@&#8203;chikoski](https://github.com/chikoski) made their first contribution in [bytecodealliance/cargo-component#278
-   [@&#8203;calvinrp](https://github.com/calvinrp) made their first contribution in [bytecodealliance/cargo-component#287

**Full Changelog**: bytecodealliance/cargo-component@v0.11.0...v0.12.0

### [`v0.11.0`](https://github.com/bytecodealliance/cargo-component/releases/tag/v0.11.0)

[Compare Source](https://github.com/bytecodealliance/cargo-component/compare/v0.10.1...v0.11.0)

#### Compatibility

-   Wasmtime: 17.0.0+
-   WASI: 0.2.0
-   Warg (registry support): 0.4.0

#### What's Changed

-   Update wit-bindgen and wasm-tools. by [@&#8203;sunfishcode](https://github.com/sunfishcode) in [bytecodealliance/cargo-component#266
-   Synchronize artifact componentization.  by [@&#8203;peterhuene](https://github.com/peterhuene) in [bytecodealliance/cargo-component#270
-   Bump version to 0.11.0. by [@&#8203;peterhuene](https://github.com/peterhuene) in [bytecodealliance/cargo-component#271

**Full Changelog**: bytecodealliance/cargo-component@v0.10.1...v0.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhuene peterhuene peterhuene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for with from wit-bindgen
2 participants
@sehnryr @peterhuene